fix(security): warn on non-RevenueCat API host; protect Authorization from RC_HEADERS - #153
Merged
Merged
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c599641. Configure here.
joshdholtz
force-pushed
the
dx-sec-credential-hardening
branch
from
August 26, 2026 18:21
c599641 to
2148eb4
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2148eb4. Configure here.
A stray or hostile RC_HEADERS entry could otherwise swap out the CLI's credential. Other header overrides still work. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
joshdholtz
force-pushed
the
dx-sec-credential-hardening
branch
from
August 27, 2026 12:25
34a0be2 to
a8bbf01
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a8bbf01. Configure here.
fire-at-will
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One safety net:
RC_HEADERScan no longer overrideAuthorization, so a stray or hostile header can't swap out your RevenueCat credential. Other headers still work.(The RC_BASE_URL half moved to #160, which locks endpoint overrides to dev builds.)
Note
Low Risk
Narrow security hardening in shared HTTP header application; only behavior change is blocking Authorization overrides from RC_HEADERS.
Overview
RC_HEADERS can still add or override most custom headers on RevenueCat API traffic, but
Authorizationis now ignored when those headers are merged onto outgoing requests.httpx.Applyskips anyAuthorizationentry (case-insensitive) from parsedRC_HEADERS, so a misconfigured or hostile header line cannot replace the CLI’s stored API key or OAuth credential. Other headers continue to override defaults as before. README documents the exception, and the apply test now expects the preset bearer token to survive whenRC_HEADERSincludesAuthorization.Reviewed by Cursor Bugbot for commit a8bbf01. Bugbot is set up for automated code reviews on this repo. Configure here.