Skip to content

fix: seat the filter clear X as a hairline-split segment of the options pill - #403

Merged
dastratakos merged 2 commits into
mainfrom
dastratakos/filter-x-button-style
Aug 21, 2026
Merged

fix: seat the filter clear X as a hairline-split segment of the options pill#403
dastratakos merged 2 commits into
mainfrom
dastratakos/filter-x-button-style

Conversation

@dastratakos

@dastratakos dastratakos commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The clear-filters X on the sessions options control was a floating 20px disc with its own fill inside the pill. It is now the pill's own right segment: full height, split from the filter names by a vertical hairline, rounded only on its outer corners, with no background of its own at rest — so the control reads as one joint button with two presses, the way Linear seats a filter's clear.
  • Hover now names the press it will take: the pill lights whole only for the toggle's own hover (or while the sheet is open), and the X segment carries its own hover fill against a resting pill.
  • The style guard test follows the seat: it now asserts the hairline split, the full-height stretch, and the right-only radius instead of the disc's dimensions.

Evidence

  • Platform-independent checks: ./scripts/check.sh passed (exit 0)
  • macOS Electron verification (./scripts/verify.sh): not run (Linux cloud agent; CI supplies automated visual evidence)

Physical-device evidence

  • Screenshot or screen recording: not attached
  • Physical-notch check: not performed
  • Device/display configuration: not recorded

🤖 Generated with Claude Code


Open workspace in Conductor

Automated visual evidence

Download the deterministic macOS evidence · workflow run

  • Commit: 459490c85676aeb4752abf4a9e077a7137bf3c0c
  • Scenario: smoke
  • Physical-notch check: not performed by CI

…ns pill

The X was a floating disc with its own fill inside the pill. It is now the
pill's right segment, full height, split from the filter names by a vertical
hairline, so the control reads as one joint button with two presses. The pill
lights only for the toggle's own hover, and the X segment carries its own, so
a hover names the press it will take.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
luke-web Skipped Skipped Aug 21, 2026 6:08am

Request Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5edded3. Configure here.

Comment thread apps/desktop/src/renderer/styles/sessions.css
The global button reset zeroes the border but not the background, so the
segment needs its own background: none to sit flush at rest.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@dastratakos
dastratakos added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit 6533359 Aug 21, 2026
10 checks passed
@dastratakos
dastratakos deleted the dastratakos/filter-x-button-style branch August 21, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant