feat(desktop): put the Ask Luke composer at the foot of the History tab - #643
Merged
Conversation
The History tab is where a typed ask's reply lands as a bubble, yet the field that asks lived only under the sessions list, so reading the thread and continuing it meant a tab change between every exchange. The same composer now stands at the thread's foot, addressed to the same conversation, inside the subtree recordings never see. The ask key still lands in whichever field is showing and gives way to the sessions list only from Settings, which holds none; Luke's guide learns where the second field stands. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AskLukecomponent wired to the sameaskhandler, so a typed ask from either tab enters the one conversation, and on History the reply lands as a bubble directly above the field that asked.ph-no-capturesubtree, so a draft there is as unrecorded as the thread around it. Nothing new leaves the machine.ConversationHistoryPaneltest covers the field in the empty and threaded states and its placement after the list.Evidence
./scripts/check.shpassed (exit 0) on the Linux cloud workspace, including the newconversation-history-paneltest../scripts/verify.sh):not run locally(Linux workspace); CI's macOS job runs it and links the evidence below.Automated visual evidence
Download the deterministic macOS evidence · workflow run
0d8e9ef67074d0ed78273ceddd02de7a893b0cd4smokePhysical-device evidence
not attachednot performednot recordedNotes
🤖 Generated with Claude Code
Open workspace in Conductor
Open in Alchemize