feat(ios): add the Luke icon to the Apple Watch app - #657
Merged
Conversation
The LukeWatch target shipped with no app icon, so the watch home screen drew a blank circle. watchOS masks every icon to a circle and takes a single appearance, so the icon is a second 1024 PNG cut from the full-bleed dark iOS drawing rather than a second drawing: space black is the tile that reads on the watch's black home screen, the same call the packaged .icns makes. The watch target's build settings now name the appiconset, as the iPhone target's do, and the brand README's recipe cuts the watch PNG beside the iPhone's. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LukeWatchtarget shipped with no app icon, so the watch home screen drew a blank circle beside the iPhone app's Luke face. This gives the watch app the same icon, using the iPhone appiconset as the reference.apps/ios/LukeWatch/Assets.xcassets/AppIcon.appiconset/, cut from the existing full-bleeddesign/brand/icon/luke-icon-ios-dark.svgrather than a second drawing. Space black is the tile that reads on the watch's black home screen, the same call the packaged.icnsmakes for macOS. The glyph keeps its 58% share of the visible tile, which for a circular mask is the diameter, and its bounding box sits well inside the circle.Luke.xcodeproj: the twoLukeWatchbuild configurations now setASSETCATALOG_COMPILER_APPICON_NAME = AppIcon, as the iPhone target's do. No other project change.design/brand/README.mdgains thersvg-convertline that cuts the watch PNG beside the iPhone ones and a note in the files table; the generator's iOS icon comment records that the dark cut also serves the watch, since changing that drawing now changes two icons. No SVG changed, sogenerate-brand-assets.mjs --checkis unaffected.Evidence
./scripts/check.shpassed (repository contract checks, Biome, typecheck, tests, build)../scripts/verify.sh):not run— no desktop change; nothing outsideapps/ios/anddesign/is touched.Mac-certified results (053d28e, watchOS 26.5 / Xcode 26.6)
Automated visual evidence
Download the deterministic macOS evidence · workflow run
053d28ebc63ba38a1172d2e1dae5220aaead5823smokePhysical-device evidence
not attached— the compiled asset catalog was inspected withassetutilinstead; the PNG itself is in the diff.not performed— not applicable, watchOS change onlyNotes
Open workspace in Conductor
Open in Alchemize