Converted mutation point cost to float #4154

athariqk · 2023-02-23T16:00:25Z

Brief Description of What This PR Does

As discussed in #4150. MP is rounded to 3 fractional digits in the GUI elements.

Of course needs further testing.

Related Issues

Fixes #4150.

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

PR author has checked that this PR works as intended and doesn't
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
Initial code review passed (this and further items should not be checked by the PR author)
Functionality is confirmed working by another person (see above checklist link)
Final code review is passed and code conforms to the
styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

Currently translated at 90.7% (1214 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/ru/

Currently translated at 99.8% (1336 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/zh_Hans/

Currently translated at 84.7% (1134 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Currently translated at 86.9% (1164 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Currently translated at 90.2% (1207 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Currently translated at 90.5% (1211 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Currently translated at 90.5% (1212 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Currently translated at 90.6% (1213 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Currently translated at 92.6% (1239 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Currently translated at 92.6% (1240 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Currently translated at 93.4% (1250 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/

…hrive-thrive-game Translations update from Thrive - Weblate

…n the cell (#3926) * Add guard for taking negative compounds and remove apparently unnecessary multiplier * Remove extra change and add comment Co-authored-by: Henri Hyyryläinen <henri.hyyrylainen@gmail.com>

* Updated submodule * Updated translation progress * Updated credits * Bump version to 0.6.0 * Updated the JSON and zip library versions * Update submodule again * Revert update to SharpZipLib as it caused broken saves follow up issue: #3925 * Explain the multiply by 2 in the compound venting threshold

* Rebalanced photosynthesis and reproduction * Significantly reduced iron amount in small chunks * Fixed format mistake

… compounds in patch details (#3931) * Remove unused ComputeRandomRadianRotation function Closes #3883 * Remove '%' suffix from patch details Closes #3909 * Fix culture with ToString * Fix indentation * Add using directive

Currently translated at 90.7% (1214 of 1338 strings) Co-authored-by: tabat-dectocoder <aliks234066aliks@gmail.com> Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/ru/ Translation: Thrive/Thrive Game

Currently translated at 100.0% (1338 of 1338 strings) Co-authored-by: Pan Shoucheng <848516934@qq.com> Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/zh_Hans/ Translation: Thrive/Thrive Game

Currently translated at 99.8% (1336 of 1338 strings) Translated using Weblate (Finnish) Currently translated at 59.1% (791 of 1338 strings) Co-authored-by: Henri Hyyryläinen <hhyyrylainen@revolutionarygamesstudio.com> Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/fi/ Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/zh_Hans/ Translation: Thrive/Thrive Game

Currently translated at 94.3% (1263 of 1338 strings) Translated using Weblate (English) Currently translated at 100.0% (1338 of 1338 strings) Co-authored-by: Sur3 <sur3@gmx.de> Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/ Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/en/ Translation: Thrive/Thrive Game

Currently translated at 94.3% (1263 of 1338 strings) Co-authored-by: Allstreamer <cbredenbach@gmail.com> Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/ Translation: Thrive/Thrive Game

…hrive-thrive-game Translations update from Thrive - Weblate

Moved a few more platform handling methods to the common module from scripts

) * Added in proper prevention of absorbing negative compound amounts * Simplified one line of the AI code automatically by my IDE * Adjusted a comment * Updated submodule

* Added multicellular prototype axon and myofibril organelles they don't really do anything yet but can be placed * Added translations * Tweaked the axon visuals and the size of the myofibril

…into convert_mp_to_float

* Add auto-evo prediction calculating icon * Clarified file name * Costumizable change indicator's rect size * Fix wonky size * Make invalid icon size be the same as the normal icon size by default

…pedia museum (#4166) * Trigger `MainMenu.OnEnteringGame` in autoevo explore tool and thriveopedia museum * Replace a call to `MarkCurrentVersionAsPlayed` in save load to `OnEnteringGame`.

Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

hhyyrylainen · 2023-02-27T10:13:28Z

Is the rigidity handling for when no new step is permitted due to being out of MP now handled correctly here? Those are the only files in this PR I've not marked as read by me.

athariqk · 2023-02-27T10:15:53Z

Working on it.

…sliding action

…y-Games/Thrive into convert_mp_to_float

athariqk · 2023-02-27T16:55:42Z

src/microbe_stage/editor/CellEditorComponent.cs

+            // int stepsToCutOff = (int)Math.Ceiling((cost - Editor.MutationPoints) / costPerStep);
+            // data.NewRigidity -= (desiredRigidity - previousRigidity > 0 ? 1 : -1) * stepsToCutOff /
+            //    Constants.MEMBRANE_RIGIDITY_SLIDER_TO_VALUE_RATIO;


This code made the slider able to stop at a maximum affordable MP when you jump out of the affordable range.

I can't figure out the maths for this, this always breaks at certain cost multipliers so I commented this out and the glitchy bug is fixed at least.

84634E1A607A · 2023-02-27T23:52:46Z

src/microbe_stage/editor/CellEditorComponent.cs

+    protected float GetAdjustedCost(float cost)
+    {
+        return Mathf.Clamp(
+            cost * CostMultiplier, Constants.MINIMUM_MUTATION_POINTS_COST, Constants.BASE_MUTATION_POINTS);


Maybe this is the cause that breaks the mutation point math.

This is required to cap MP at a minimum as hh requested, a fix in spite of this is needed.

hhyyrylainen · 2023-02-28T09:02:25Z

I assume there's still some fixing to be done on this, @-mention me if I miss when this is actually functionally ready.

hhyyrylainen · 2023-06-05T11:48:45Z

I will perform a repository history rewrite on the Thrive repo on the 26th of June. This will cause a small disruption for PRs, which is possible to avoid if the PR can be merged before that.

For more info see: https://forum.revolutionarygamesstudio.com/t/rewriting-the-repository-history-to-remove-large-binary-files/991

revolutionary-bot · 2023-06-22T11:38:01Z

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

github-actions · 2023-09-25T02:04:29Z

This PR has been inactive for a while and as such is being marked
stale. This PR will be automatically closed if this stays stale
for a while.

If this is still being worked on / will probably resume work at
some point please feel free to continue working on this and reopen
this in case this was already automatically closed.

github-actions · 2023-10-26T02:04:18Z

This PR is being automatically closed due to being stale. Please
only reopen this if work is actually resuming on this PR. We have
automatic PR closing to make sure that PRs that never get finished
aren't forever hanging out in the list of open PRs.

simsanutiy and others added 30 commits December 8, 2022 09:03

Translated using Weblate (Russian)

f7d2009

Currently translated at 90.7% (1214 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/ru/

Translated using Weblate (Chinese (Simplified))

c75928e

Currently translated at 99.8% (1336 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/zh_Hans/

Translated using Weblate (German)

2ab0a76

Currently translated at 84.7% (1134 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

471fbce

Currently translated at 86.9% (1164 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

d2611b9

Currently translated at 90.2% (1207 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

c7051a1

Currently translated at 90.5% (1211 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

f36f1e0

Currently translated at 90.5% (1212 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

6a4f950

Currently translated at 90.5% (1212 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

0767b0b

Currently translated at 90.5% (1212 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

f659af8

Currently translated at 90.6% (1213 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

2f248da

Currently translated at 92.6% (1239 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

02c32f7

Currently translated at 92.6% (1240 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

2383a66

Currently translated at 92.6% (1240 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

3b8debc

Currently translated at 92.6% (1240 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Translated using Weblate (German)

f2da5be

Currently translated at 93.4% (1250 of 1338 strings) Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/

Update translation files

7a28854

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: Thrive/Thrive Game Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/

Merge pull request #3903 from revolutionary-translation-bot/weblate-t…

79d5ee6

…hrive-thrive-game Translations update from Thrive - Weblate

Fix infinite compound venting due to having compounds over capacity i…

baa0e97

…n the cell (#3926) * Add guard for taking negative compounds and remove apparently unnecessary multiplier * Remove extra change and add comment Co-authored-by: Henri Hyyryläinen <henri.hyyrylainen@gmail.com>

Balancepass 0.6.0 (#3928)

f90acf2

* Rebalanced photosynthesis and reproduction * Significantly reduced iron amount in small chunks * Fixed format mistake

Updated code checking tools again (#3932)

7fbc7f7

Translated using Weblate (Russian)

c041068

Currently translated at 90.7% (1214 of 1338 strings) Co-authored-by: tabat-dectocoder <aliks234066aliks@gmail.com> Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/ru/ Translation: Thrive/Thrive Game

Translated using Weblate (Chinese (Simplified))

9f480a9

Currently translated at 100.0% (1338 of 1338 strings) Co-authored-by: Pan Shoucheng <848516934@qq.com> Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/zh_Hans/ Translation: Thrive/Thrive Game

Translated using Weblate (German)

b59ba76

Currently translated at 94.3% (1263 of 1338 strings) Co-authored-by: Allstreamer <cbredenbach@gmail.com> Translate-URL: https://translate.revolutionarygamesstudio.com/projects/thrive/thrive-game/de/ Translation: Thrive/Thrive Game

Merge pull request #3929 from revolutionary-translation-bot/weblate-t…

de1770a

…hrive-thrive-game Translations update from Thrive - Weblate

Moved a few more platform handling methods to the common module (#3940)

fe14c67

Moved a few more platform handling methods to the common module from scripts

Added in proper prevention of absorbing negative compound amounts (#3939

8e5dff5

) * Added in proper prevention of absorbing negative compound amounts * Simplified one line of the AI code automatically by my IDE * Adjusted a comment * Updated submodule

athariqk and others added 10 commits February 24, 2023 20:56

Turn into constant and fixed leftover

5abd78a

Added multicellular prototype axon and myofibril organelles (#4161)

9a32369

* Added multicellular prototype axon and myofibril organelles they don't really do anything yet but can be placed * Added translations * Tweaked the axon visuals and the size of the myofibril

Merge branch 'master' of https://github.com/Revolutionary-Games/Thrive …

f427296

…into convert_mp_to_float

Revert back rigidity to int

f634c58

Add auto-evo prediction calculating icon (#4162)

a5c5838

* Add auto-evo prediction calculating icon * Clarified file name * Costumizable change indicator's rect size * Fix wonky size * Make invalid icon size be the same as the normal icon size by default

Trigger MainMenu.OnEnteringGame in autoevo explore tool and thriveo…

ec28a33

…pedia museum (#4166) * Trigger `MainMenu.OnEnteringGame` in autoevo explore tool and thriveopedia museum * Replace a call to `MarkCurrentVersionAsPlayed` in save load to `OnEnteringGame`.

Fix oversized editor tab buttons (#4165)

5a2cf6b

Updated Karambolo package and common submodule

e6ae2d9

Merge branch 'master' into convert_mp_to_float

8f5657a

athariqk added 2 commits February 27, 2023 23:45

Cap mutation points to a minimum, applied patch for glitchy rigidity …

7b44524

…sliding action

Merge branch 'convert_mp_to_float' of https://github.com/Revolutionar…

a3d4cb1

…y-Games/Thrive into convert_mp_to_float

athariqk commented Feb 27, 2023

View reviewed changes

84634E1A607A reviewed Feb 27, 2023

View reviewed changes

hhyyrylainen modified the milestones: Release 0.6.2, Release 0.6.3 Apr 22, 2023

hhyyrylainen modified the milestones: Release 0.6.3, Release 0.6.4 Jun 22, 2023

hhyyrylainen force-pushed the master branch from c7aa835 to b127aa7 Compare June 26, 2023 08:01

github-actions bot added the stale label Sep 25, 2023

github-actions bot closed this Oct 26, 2023

Thrive Planning automation moved this from In progress to Done Oct 26, 2023

hhyyrylainen mentioned this pull request May 1, 2024

Rigidity slider breaks when trying to move it at exactly 0 MP #4150

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Converted mutation point cost to float #4154

Converted mutation point cost to float #4154

athariqk commented Feb 23, 2023

hhyyrylainen commented Feb 27, 2023

athariqk commented Feb 27, 2023

athariqk Feb 27, 2023

84634E1A607A Feb 27, 2023

athariqk Feb 28, 2023

hhyyrylainen commented Feb 28, 2023

hhyyrylainen commented Jun 5, 2023

revolutionary-bot commented Jun 22, 2023

github-actions bot commented Sep 25, 2023

github-actions bot commented Oct 26, 2023

Converted mutation point cost to float #4154

Converted mutation point cost to float #4154

Conversation

athariqk commented Feb 23, 2023

hhyyrylainen commented Feb 27, 2023

athariqk commented Feb 27, 2023

athariqk Feb 27, 2023

Choose a reason for hiding this comment

84634E1A607A Feb 27, 2023

Choose a reason for hiding this comment

athariqk Feb 28, 2023

Choose a reason for hiding this comment

hhyyrylainen commented Feb 28, 2023

hhyyrylainen commented Jun 5, 2023

revolutionary-bot commented Jun 22, 2023

github-actions bot commented Sep 25, 2023

github-actions bot commented Oct 26, 2023