-
-
Notifications
You must be signed in to change notification settings - Fork 575
Removed option to disable passive reproduction #5970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed option to disable passive reproduction #5970
Conversation
Removed mentions/variables of passive reproduction in new game and difficulty classes, made it so `PassiveGainOfReproductionCompounds` is true by default, removed passive reproduction button from custom difficulty/advanced new game menu. Fix for #5964
hhyyrylainen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one slight remark on these changes not going as far as I think they should in removing the feature.
|
Can I ask why this was closed? This was very close to being completed. |
|
I was trying to rename my branches but doing so closed the PR's automatically... won't happen again, apologies. |
|
Thanks for clarifying. I commented as I was slightly worried that it was either a mistake or what I've also seen is that some people think they need to recreate their PRs to fix something instead of doing a force push. |
This reverts commit 84d722b.
hhyyrylainen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code change is now completely correct. I'll help with the merge conflict to get this merged for today's BOTD.
…tion_difficulty_option
Brief Description of What This PR Does
Removed mentions/variables of passive reproduction in new game and difficulty classes, made it so
PassiveGainOfReproductionCompoundsis true by default, removed passive reproduction button from custom difficulty/advanced new game menu. Fix for #5964Related Issues
closes #5964
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.