Skip to content

Conversation

@La-ryssa
Copy link
Contributor

@La-ryssa La-ryssa commented Feb 28, 2025

Brief Description of What This PR Does

Removed mentions/variables of passive reproduction in new game and difficulty classes, made it so PassiveGainOfReproductionCompounds is true by default, removed passive reproduction button from custom difficulty/advanced new game menu. Fix for #5964

Related Issues

closes #5964

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

Removed mentions/variables of passive reproduction in new game and difficulty classes, made it so `PassiveGainOfReproductionCompounds` is true by default, removed passive reproduction button from custom difficulty/advanced new game menu. Fix for #5964
@hhyyrylainen hhyyrylainen requested review from a team February 28, 2025 17:43
@hhyyrylainen hhyyrylainen added this to the Release 0.8.2 milestone Feb 28, 2025
@La-ryssa La-ryssa marked this pull request as ready for review February 28, 2025 17:50
@hhyyrylainen hhyyrylainen changed the title removed passive reproduction difficulty option Removed option to disable passive reproduction Mar 3, 2025
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one slight remark on these changes not going as far as I think they should in removing the feature.

@La-ryssa La-ryssa requested a review from hhyyrylainen March 3, 2025 14:14
@La-ryssa La-ryssa self-assigned this Mar 4, 2025
@La-ryssa La-ryssa closed this Mar 4, 2025
@La-ryssa La-ryssa deleted the 5964_remove_passive_reproduction_difficulty_option branch March 4, 2025 17:36
@github-project-automation github-project-automation bot moved this from In progress to Done in Thrive Planning Mar 4, 2025
@La-ryssa La-ryssa restored the 5964_remove_passive_reproduction_difficulty_option branch March 4, 2025 17:41
@hhyyrylainen
Copy link
Member

Can I ask why this was closed? This was very close to being completed.

@La-ryssa
Copy link
Contributor Author

La-ryssa commented Mar 5, 2025

I was trying to rename my branches but doing so closed the PR's automatically... won't happen again, apologies.

@La-ryssa La-ryssa reopened this Mar 5, 2025
@github-project-automation github-project-automation bot moved this from Done to In progress in Thrive Planning Mar 5, 2025
@hhyyrylainen
Copy link
Member

Thanks for clarifying. I commented as I was slightly worried that it was either a mistake or what I've also seen is that some people think they need to recreate their PRs to fix something instead of doing a force push.

Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code change is now completely correct. I'll help with the merge conflict to get this merged for today's BOTD.

@hhyyrylainen hhyyrylainen merged commit c546229 into Revolutionary-Games:master Mar 7, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Thrive Planning Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove the "disable passive reproduction" difficulty option checkbox

2 participants