fix: [sc-87908] JSON Marshal Errors Silently Swallowed in result.go#56
Merged
mlataza merged 1 commit intoApr 19, 2026
Merged
Conversation
mlataza
deleted the
bug/sc-87908/json-marshal-errors-silently-swallowed-in
branch
April 19, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorResultBytesandresultBytesininternal/interpreter/result.gowere discardingjson.MarshalIndenterrors with_, returningnilbytes on failure with no log entry and no signal to the callerhclog.Logger, check the marshal error, log it vialogger.Error, and return a hardcoded valid JSON fallback so neither function can ever returnnilor empty bytesbase_executor.goandmessage.goupdated to pass the already-available logger; tests updated accordingly with new assertions that returned bytes are always non-nil and valid JSONTest plan
go test ./internal/interpreter/...— all tests passgo vet ./internal/interpreter/...— no new warningsTestErrorResultBytesNeverNilandTestResultBytesNeverNilassert non-empty, valid JSON output from both functionsTestErrorResultBytesandTestResultBytesstill validate correct field values