fix: [sc-89444] Derive per-cycle context so in-flight commands cancel on disconnect#71
Merged
mlataza merged 1 commit intoMay 13, 2026
Conversation
… on disconnect Each MQTT connection cycle now derives its own context from the parent and cancels it when the cycle ends. Commands running under exec.CommandContext are interrupted on disconnect, freeing worker slots before the next cycle begins. The deferred cleanup runs MQTT teardown first, then cycleCancel before wg.Wait so a hung command can't block worker drain. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runCyclenow derives a freshcycleCtxfrom the parent context on each invocation. The cycle context is cancelled when the cycle ends (disconnect or stop), which propagates throughprocessMessage→executor.Execute→exec.CommandContextto terminate any in-flight command.cycleCancel()→close(msgQueue)→wg.Wait(). Cancelling beforewg.Waitis required so a hung command cannot block worker drain.Test plan
go build ./...go test ./cmd/agent_smith/...(existing suite green, including the worker/queue/lost-channel regression tests)🤖 Generated with Claude Code