Merged
Conversation
Owner
RhysU
commented
Jan 11, 2026
RhysU
commented
- Using PyArg_ParseTupleAndKeywords now to allow keyword arguments
- Enhanced test_ar.py to verify both positional and keyword argument calls produce identical results
- Modified ar_arsel() to use PyArg_ParseTupleAndKeywords instead of PyArg_ParseTuple, enabling keyword argument support - Added kwlist array defining parameter names: data, submean, absrho, criterion, minorder, maxorder - Updated method flags to include METH_KEYWORDS and added PyCFunction cast - Enhanced test_ar.py to verify both positional and keyword argument calls produce identical results - Added values_equal() helper function to properly compare values including NaN and infinity cases
RhysU
added a commit
that referenced
this pull request
Jan 11, 2026
- Modified ar_arsel() to use PyArg_ParseTupleAndKeywords instead of PyArg_ParseTuple, enabling keyword argument support - Added kwlist array defining parameter names: data, submean, absrho, criterion, minorder, maxorder - Updated method flags to include METH_KEYWORDS and added PyCFunction cast - Enhanced test_ar.py to verify both positional and keyword argument calls produce identical results - Added values_equal() helper function to properly compare values including NaN and infinity cases Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.