Skip to content

CI pipeline smoke test#2

Open
RidhaOracle wants to merge 51 commits into
trunkfrom
codex/ci-pipeline-smoke
Open

CI pipeline smoke test#2
RidhaOracle wants to merge 51 commits into
trunkfrom
codex/ci-pipeline-smoke

Conversation

@RidhaOracle

Copy link
Copy Markdown
Owner

Purpose: exercise the pull-request automation newly merged into trunk with a behavior-neutral comment correction.\n\nExpected coverage:\n- PR Build\n- MTR\n- Format Check\n- Auto Label (tests)\n- Codex PR Review for a trusted actor\n- Assign Code Owners after OCA Verified is applied\n\nThis is a temporary smoke-test PR and should be closed after the checks are verified.

Update workflows and contributor docs, and remove the obsolete PR template consistency check.
Add the required 2026 Oracle copyright notice to the GitHub contribution automation and CI helper files so server-side validation accepts the change. Keep shell shebangs as the first line.
@github-actions github-actions Bot added the tests Changes touching test code or test data label Jul 13, 2026
@github-actions

Copy link
Copy Markdown
  1. Change summary

Corrects grammar in a safe_process documentation comment by adding “the.” No runtime behavior changes.

  1. Review findings

No high-confidence issues found.

  1. Test gaps or risks

No tests needed for this comment-only change. git diff --check passes.

Replace the blocked third-party Codex GitHub Action with a repository-owned, standard-library Responses API client. Load the client from the PR base SHA, verify merge parents and current write permission, treat the PR checkout only as bounded diff data, and expose the API key only to the trusted client.

Pin the remaining GitHub-owned actions, validate and base64-transport review output, restrict the posting job to issues:write, and fail the final status unless both review generation and comment delivery succeed.

Add unit coverage for event validation, merge verification, bounded Git isolation, request authentication, response parsing, Unicode and size limits, and output encoding.
Replace full upstream commit SHA pins with the requested actions/github-script@v7 and actions/checkout@v4 references.
Keep the pull request focused on the production workflow and review client by removing the standalone unit test file as requested.
Replace Codex action with repository-owned API reviewer
@RidhaOracle RidhaOracle force-pushed the codex/ci-pipeline-smoke branch from c85a680 to 5814190 Compare July 13, 2026 17:06
Grant pull-requests: write to the separately permissioned post_feedback job. The repository-owned reviewer generated feedback successfully, but GitHub rejected the issue-comment request with HTTP 403 when the job had only issues: write.
…ssion

Allow the reviewer to comment on pull requests
Make a behavior-neutral comment correction under mysql-test to exercise the PR build, MTR, formatting, labeling, review, and ownership automation merged into trunk.
Temporarily mask the SafeProcess child exit status in the smoke-test PR so the synchronized Codex review has a concrete, high-confidence defect to identify. This change is only for validating review behavior.
Create a fresh synchronize event without changing the controlled review defect.
Correct a possessive typo while preserving the controlled Codex review probe in the pull request.
Trigger a fresh pull_request_target synchronization after rebasing the smoke-test branch onto the trunk version of the repository-owned reviewer.
Trigger a fresh pull_request_target run after merging the pull-requests: write permission for the post_feedback job.
@RidhaOracle RidhaOracle force-pushed the codex/ci-pipeline-smoke branch from 5814190 to 64938fd Compare July 13, 2026 17:22
@github-actions

Copy link
Copy Markdown

1. Change summary

Corrects two comments in safe_process.cc, but also changes safe_process to return success when a child exits normally, regardless of the child’s actual exit status.

2. Review findings

  • High severity — mysql-test/lib/My/SafeProcess/safe_process.cc:161
    Replacing exit(exit_code) with exit(0) suppresses all nonzero child exit codes. Callers and CI may therefore treat failed child processes as successful, potentially hiding test failures. This also contradicts the adjacent comment and the PR’s stated behavior-neutral purpose.
    Recommended correction: Restore exit(exit_code) and keep only the intended comment corrections.

3. Test gaps or risks

The exit-status change would require explicit tests proving that a child’s nonzero exit code is propagated. For a comment-only smoke-test PR, the safer correction is to remove the behavioral change entirely.

@github-actions github-actions Bot added MTR Failed MTR suite failed Build Passed PR build passed labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Passed PR build passed MTR Failed MTR suite failed OCA Verified tests Changes touching test code or test data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant