fix(connector): name the oh-my-pi session after COTAL_NAME at join

[sealedsecurity-bot]

Names the oh-my-pi mesh session after COTAL_NAME so every agent's pane/terminal title reflects who it is, instead of a generic auto-title.

Problem

The connector launcher forwards COTAL_NAME into the spawned session's environment, but the extension had no agent-reachable way to set the session (pane/terminal) title — so every agent showed a generic auto-title regardless of its mesh identity. In a multi-pane wave that makes panes indistinguishable.

Fix

In the session_start handler (extensions/connector-oh-my-pi/src/extension.ts), after the hasUI/identity guard and started = true, call pi.setSessionName(config.name) when a name is resolved. Properties:

• Guarded — only sets when the session name is unset (!ctx.sessionManager.getSessionName()), so a resumed or manually-/rename'd session is never clobbered.
• Best-effort — a setSessionName failure is caught and logged, never breaking the mesh-join (the title is cosmetic; the join is not).
• Interactive-only — rides the existing hasUI gate, so subagent/print/RPC sessions stay off the mesh and untouched.

Test

Extends extensions/connector-oh-my-pi/oh-my-pi-extension.smoke.ts with session-name regression coverage (4 behaviors): title set when unset, no-clobber when already named, non-interactive skip, and best-effort on setSessionName rejection. Red-green demonstrated for the set + no-clobber cases. pnpm --filter @cotal-ai/oh-my-pi run smoke:extension → green; connector typecheck + build green.

Base

Stacked on zheng-connector-upstream (PR #5, the zod-migrated SDK-16.3.12 connector that owns extension.ts's session_start handler). Retargets to sealed-fork when #5 merges.

Co-Authored-By: seal noreply@sealedsecurity.com

[coderabbitai]

Warning

Review limit reached

@seal-agent, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 659728d5-c422-4f28-a637-5e2705668961

📥 Commits

Reviewing files that changed from the base of the PR and between aacbea9 and 4222fdd.

📒 Files selected for processing (2)

• extensions/connector-oh-my-pi/oh-my-pi-extension.smoke.ts
• extensions/connector-oh-my-pi/src/extension.ts

📝 Walkthrough

Walkthrough

The OMP extension's session_start handler was changed to async, adding a detached best-effort session rename to config.name after mesh start, gated on interactivity and existing session name, with errors caught and logged. The corresponding smoke test was expanded to verify this behavior across several scenarios.

Changes

Session Title Rename on session_start

Layer / File(s)	Summary
Async session_start handler with best-effort rename extensions/connector-oh-my-pi/src/extension.ts	Handler is now async; after starting the mesh agent for interactive sessions, it conditionally sets the session name via setSessionName only if unset, catching and logging errors without blocking the mesh join.
Smoke test fake API and expanded scenarios extensions/connector-oh-my-pi/oh-my-pi-extension.smoke.ts	Fake Pi API now records setSessionName calls and can simulate rejection; test rewritten with richer ctx shape and five scenarios covering non-interactive skip, unnamed/interactive rename, already-named skip, rename rejection, and getSessionName throw, using settle() to await detached work.

Estimated code review effort: 2 (Simple) | ~12 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Pi
  participant Extension
  participant MeshAgent
  participant SessionManager

  Pi->>Extension: session_start(ctx)
  alt ctx.hasUI === false
    Extension-->>Pi: no-op, no rename
  else interactive
    Extension->>MeshAgent: start()
    Extension->>SessionManager: getSessionName()
    alt name is undefined
      Extension->>Pi: setSessionName(config.name)
      alt setSessionName rejects
        Extension->>Extension: catch and log warning
      end
    else name already set
      Note over Extension: skip rename
    end
  end

Loading

Poem

A rabbit hops through code so neat,
Renaming sessions, best-effort feat,
If names resist or reads go wrong,
The mesh join still sings its song 🎶
Hop, settle, test — all snug and tight! 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: naming the oh-my-pi session from COTAL_NAME during join.
Description check	✅ Passed	The description is directly related and matches the implementation and test changes in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cotal-connector-session-title

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This PR names interactive oh-my-pi mesh sessions after the configured Cotal identity.

• Adds best-effort session naming after the mesh join starts.
• Preserves existing manual or resumed session names.
• Skips title work for non-interactive sessions.
• Adds smoke coverage for the rename and join behavior.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
extensions/connector-oh-my-pi/src/extension.ts	Starts the mesh agent before running guarded best-effort session naming.
extensions/connector-oh-my-pi/oh-my-pi-extension.smoke.ts	Adds smoke coverage for unset names, existing names, non-interactive sessions, rejected renames, and guard-read failures.

_{Reviews (3): Last reviewed commit: "fix(connector): never gate the mesh-join..." | Re-trigger Greptile}

[cubic-dev-ai]

All reported issues were addressed across 2 files

<sub>Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.

Fix all with cubic | Re-trigger cubic</sub>