docs(compass-gtk4): T6 prose sweep + GTK4-default ledger encode (RIG-2820) - #703
Merged
Merged
Conversation
…2820) Close the GTK4 migration (RIG-1770): sweep the remaining gtk3/GTK3 prose left by the T2-T5 core flip (#682) and encode the GTK4-default decision row. - Sweep 13 stale gtk3/GTK3 comment references across devenv.nix, gtk-e2e-env.nix, chromium-e2e-env.nix, gtk-closure.nix, ci.yml, and go/e2e/client_mode_test.go to gtk4 (T3 already flipped the functional tags/closure; these were lagging comments). Also corrects the now-stale pkg-config names (gtk+-3.0 / webkit2gtk-4.1 / gdk-3.0) within the swept ranges. Acceptance: grep -ri 'gtk3' over *.nix/*.yml/*.sh/*.go is now zero. - Annotate the native-app record's Global Constraints (which names webkit2gtk-4.1) with a GTK4 amendment banner per the banner-amendment convention; frozen prose retained, not rewritten. - Encode DL-282 (GTK4 + webkitgtk-6.0 default; legacy gtk3 retired; no DL superseded). Assigned against merge-base main at encode time: RIG-2883's #695 took DL-281 concurrently, so this rebased onto its merge and renumbered 281->282. Refs RIG-2820 Ledger-impact: adds DL-282 (GTK4 default stack); no DL superseded Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-native-2820-gtk4-t6.compass-eng-docs.pages.dev Deployed from Changed pages: |
rigel-mintaka
marked this pull request as ready for review
August 28, 2026 03:27
mattwilkinsonn
approved these changes
Aug 28, 2026
rigel-mintaka
added a commit
that referenced
this pull request
Aug 28, 2026
…e forge surface (RIG-2909) The forge-oracle gate intermittently failed on TestLiveLinearListIssues: its live-Linear setup CreateIssue timed out awaiting response headers (a transient api.linear.app latency blip), failing the whole required gate on unrelated PRs. Two deterministic fixes, no retries=N (rule://no-retries): 1. Every live GitHub create is already wrapped in the bounded, ctx-aware one-shot createWithBackoff; none of the five Linear creates were. Extend createWithBackoff to also re-issue once on a transient network timeout (net.Error.Timeout / context.DeadlineExceeded through the client-timeout chain) alongside the existing GitHub secondary-rate-limit case, and wrap the five Linear creates in it. A persistent outage still fails loud after one re-issue; it never runs on the skip path. 2. Make the live oracle path-affected. It is the expensive third-party verification layered on the untagged golden-replay battery (leg 1), which already asserts the client contract on every PR with zero network. Narrow the forge trigger (ci-matrix FORGE_PATH_RE + the ci.yml in-step gate) to the forge contract surface go/internal/forge/** and drop the bare-ci.yml over-trigger that ran the whole live oracle on docs/CI-only PRs (e.g. #703). Oracle-wiring changes stay covered by the push/schedule full sweep. Refs RIG-2909 Co-authored-by: Matt Wilkinson <matt@rigel.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close the GTK4 migration (RIG-1770): sweep the remaining gtk3/GTK3 prose left
by the T2-T5 core flip (#682) and encode the GTK4-default decision row.
gtk-e2e-env.nix, chromium-e2e-env.nix, gtk-closure.nix, ci.yml, and
go/e2e/client_mode_test.go to gtk4 (T3 already flipped the functional
tags/closure; these were lagging comments). Also corrects the now-stale
pkg-config names (gtk+-3.0 / webkit2gtk-4.1 / gdk-3.0) within the swept
ranges. Acceptance: grep -ri 'gtk3' over .nix/.yml/.sh/.go is now zero.
webkit2gtk-4.1) with a GTK4 amendment banner per the banner-amendment
convention; frozen prose retained, not rewritten.
superseded). Assigned against merge-base main at encode time: RIG-2883's
docs(product): design board ingestion forge poll → webhooks (RIG-2883) #695 took DL-281 concurrently, so this rebased onto its merge and renumbered
281->282.
Refs RIG-2820
Ledger-impact: adds DL-282 (GTK4 default stack); no DL superseded
Co-authored-by: Matt Wilkinson matt@rigel.build