chore(go): raise module floor to 1.26 + absorb modernize sweep (RIG-3107) - #876
Open
rigel-mintaka wants to merge 1 commit into
Open
chore(go): raise module floor to 1.26 + absorb modernize sweep (RIG-3107)#876rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-managed-rig-3107-go.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
force-pushed
the
compass-managed/rig-3107-go-floor
branch
2 times, most recently
from
September 4, 2026 23:41
33c6519 to
65ef824
Compare
rigel-mintaka
marked this pull request as ready for review
September 4, 2026 23:43
mattwilkinsonn
approved these changes
Sep 5, 2026
…107)
The T3 NATS fabric (RIG-3107) pulls in `nats-server/v2 v2.14.6` as a test dependency, which requires a Go 1.26 language floor. This raises the `go/go.mod` directive `1.25.0`→`1.26.0` — within the pin-minus-one floor policy (the toolchain is pinned at 1.26.6 in `tools/toolchain/versions/go.nix`), and it is split out ahead of the fabric package so the floor bump and the lint fallout it surfaces are reviewable on their own.
**Why this is its own PR.** Bumping the language floor to 1.26 activates golangci-lint's 1.26-gated `modernize/newexpr` analyzer module-wide, which flags pre-existing pointer-to-value helper patterns (`func ptr(x) { return &x }` + call sites) as inlinable to the new `new(expr)` builtin. Those sites live in packages unrelated to the fabric work (`internal/guestd`, `internal/ingest`, `internal/runtime`, and the `//go:build pgtest` `internal/comms`), so folding them into the fabric PR would spread it across lanes. First lane to raise the floor owns the sweep the bump surfaces.
**Changes.** go.mod floor `1.25.0`→`1.26.0` + go.sum for the nats deps the fabric slice adds (`nats.go v1.53.1`, test-only `nats-server/v2 v2.14.6`, `google/uuid`); the shared Go `vendorHash` in `flake.nix` and `guest-image/default.nix` recomputed for the new module set; and the modernize sweep — 21 `newexpr` findings resolved across four packages: 17 `new(...)` call-site inlines (11 in `guestd/supervisor_test.go`, 3 in `runtime/microvm_lifecycle_test.go`, 1 in `ingest/notify_router_test.go`, 2 in `comms/comms_test.go`) and the 4 now-unused helper funcs (`uidPtr`, `strPtr`, `ptr`, and the pgtest-tagged `comms` `ptr`) deleted. The constant `uidPtr` sites become `new(uint32(...))` to preserve the `uint32` element type.
**Transitive dep note.** `nats-server/v2 v2.14.6` transitively bumps `github.com/klauspost/compress` `1.18.6`→`1.19.2` on a production path (reached via `minio-go/v7` object-store code, not test-only); `govulncheck` is clean at the new version and the full `-race` suite is green.
Spec-impact: none. Refs RIG-3107
Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-managed/rig-3107-go-floor
branch
from
September 5, 2026 15:06
65ef824 to
ef5f83a
Compare
mattwilkinsonn
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainThe T3 NATS fabric (RIG-3107) pulls in
nats-server/v2 v2.14.6as a test dependency, which requires a Go 1.26 language floor. This raises thego/go.moddirective1.25.0→1.26.0— within the pin-minus-one floor policy (the toolchain is pinned at 1.26.6 intools/toolchain/versions/go.nix), and it is split out ahead of the fabric package so the floor bump and the lint fallout it surfaces are reviewable on their own.Why this is its own PR. Bumping the language floor to 1.26 activates golangci-lint's 1.26-gated
modernize/newexpranalyzer module-wide, which flags pre-existing pointer-to-value helper patterns (func ptr(x) { return &x }+ call sites) as inlinable to the newnew(expr)builtin. Those sites live in packages unrelated to the fabric work (internal/guestd,internal/ingest,internal/runtime, and the//go:build pgtestinternal/comms), so folding them into the fabric PR would spread it across lanes. First lane to raise the floor owns the sweep the bump surfaces.Changes. go.mod floor
1.25.0→1.26.0+ go.sum for the nats deps the fabric slice adds (nats.go v1.53.1, test-onlynats-server/v2 v2.14.6,google/uuid); the shared GovendorHashinflake.nixandguest-image/default.nixrecomputed for the new module set; and the modernize sweep — 21newexprfindings resolved across four packages: 17new(...)call-site inlines (11 inguestd/supervisor_test.go, 3 inruntime/microvm_lifecycle_test.go, 1 iningest/notify_router_test.go, 2 incomms/comms_test.go) and the 4 now-unused helper funcs (uidPtr,strPtr,ptr, and the pgtest-taggedcommsptr) deleted. The constantuidPtrsites becomenew(uint32(...))to preserve theuint32element type.Transitive dep note.
nats-server/v2 v2.14.6transitively bumpsgithub.com/klauspost/compress1.18.6→1.19.2on a production path (reached viaminio-go/v7object-store code, not test-only);govulncheckis clean at the new version and the full-racesuite is green.Spec-impact: none. Refs RIG-3107