WIP: /devices endpoint for 'adb devices -l'#4
Merged
FrazerSeymour merged 21 commits intomasterfrom Sep 13, 2019
Merged
Conversation
compscidr
approved these changes
Sep 11, 2019
compscidr
left a comment
compscidr
left a comment
There was a problem hiding this comment.
All makes sense to me - mostly just questions. Need to learn some of this syntax though - had to google what slices were for example lol.
Contributor
Author
https://tour.golang.org and https://golang.org/doc/effective_go.html are a pretty good timer. This talk is cool too and covers a lot of ground quickly. |
…put as JSON w/o error handling.
FrazerSeymour
force-pushed
the
feature/adb-devices
branch
from
d3a7e58 to
c22e6de
Compare
…t and better reflect the data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
/devicesendpoint, which returns the result ofadb devices -lformatted as JSON.Functional so far, but this endpoint brought to light some rough edges around error handling in the server code that can be smoothed out before moving on.