Avoid bitmap conversions in non-inplace array subtraction - #555
Merged
lemire merged 3 commits intoAug 24, 2026
Conversation
Member
|
Very good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid bitmap-container conversion when subtracting runs from an array container in non-inplace
AndNotoperations. The result keeps the existing array representation and input ownership.Workload:
BenchmarkAndNotArrayArrayns/opType of Change
Changes Made
What was changed?
differencefor other arrays.Why was it changed?
How was it changed?
Testing
go test -count=1 ./...Formatting
gofmt -scleanliness check passed for the changed Go files.Fuzzing
go test -tags=gofuzz -run=TestGenerateSmatCorpus ./...go test -tags=gofuzz -run=TestSmatHits ./...Performance Impact
differencepath.Breaking Changes
None.
Related Issues
None.
Additional Notes
The focused tests also verify result boundaries and that non-inplace operations leave both inputs unchanged.
Generated by Perfloop. Measurements and checks.