This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Update homebrew tap for Java #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes <sous-chefs#566>: `caskroom/versions` was moved. Tap `homebrew/cask-versions` instead * Based on proposed changes from <sous-chefs#567> * Switch homebrew tap to homebrew/cask-versions * Make Homebrew Tap name an attribute to allow for other options
Brantone
reviewed
Jan 15, 2020
|
|
||
| This file is used to list changes made in each version of the Java cookbook. | ||
|
|
||
| ## Unreleased |
There was a problem hiding this comment.
Apprehensive about removing the Unreleased tag, because it's technically not released in the upstream and this was method by way of denoting that (and I think was a convention a year ago).
Might be worth keeping it or denoting Roblox Release or something
Brantone
reviewed
Jan 15, 2020
| default['java']['windows']['returns'] = 0 | ||
| when 'mac_os_x' | ||
| default['java']['install_flavor'] = 'homebrew' | ||
| default['java']['homebrew']['tap'] = 'homebrew/cask-versions' |
Brantone
approved these changes
Jan 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The continuation of #5 (can be closed when this PR is merged)
sous-chefs#566:
caskroom/versionswas moved. Taphomebrew/cask-versionsinsteadDescription
Issues Resolved