Skip to content

Conversation

@macostea
Copy link
Contributor

@macostea macostea commented Oct 9, 2019

Description

Change homebrew tap to "homebrew/cask-versions", as homebrew exits with code 1 when using caskroom/versions

Issues Resolved

Fixes #566

Check List

@macostea macostea requested a review from a team October 9, 2019 06:45
zirkov pushed a commit to zirkov/java that referenced this pull request Jan 15, 2020
Fixes <sous-chefs#566>:
`caskroom/versions` was moved. Tap `homebrew/cask-versions` instead

* Based on proposed changes from <sous-chefs#567>
* Switch homebrew tap to homebrew/cask-versions
* Make Homebrew Tap name an attribute to allow for other options
zirkov pushed a commit to zirkov/java that referenced this pull request Jan 15, 2020
Fixes <sous-chefs#566>:
`caskroom/versions` was moved. Tap `homebrew/cask-versions` instead

* Based on proposed changes from <sous-chefs#567>
* Switch homebrew tap to homebrew/cask-versions
* Make Homebrew Tap name an attribute to allow for other options
Copy link
Contributor

@xorima xorima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, will let a mac user confirm though @damacus @tas50 Does this seem sane to you?

If I don't hear back my Monday I'll just merge it

@xorima xorima added the Bug Something isn't working label Feb 21, 2020
@damacus damacus merged commit 8ec591a into sous-chefs:master Feb 21, 2020
@damacus
Copy link
Member

damacus commented Feb 21, 2020

Thanks for the clear explanation in the issue description, that helped merge those changes in quicker!

@xorima feel free to release this when you get a chance :)

@PowerSchill PowerSchill self-requested a review February 21, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

caskroom/versions was moved. Tap homebrew/cask-versions instead

3 participants