feat(client): regenerate for the backup encryption field removal - #177
Merged
Conversation
Upstream retired the backup `encryption` flag. It never encrypted anything at the application layer — it only suppressed downloads, and since it defaulted to false the default backup was unrestorable. Restore is now gated on graph type instead, and every completed backup is downloadable. Contract changes: - BackupListResponse gains `restore_supported`, true unless the graph is an entity graph (materialized from the extensions database) or a shared repository (platform-managed, download-only) - BackupCreateRequest drops `encryption` - BackupResponse drops `encryption_enabled` and `allow_export` Objects remain encrypted at rest with S3 SSE-AES256 and are served over TLS through short-lived signed URLs. Removing response fields breaks a consumer that reads them, but nothing does: the flag has no effect on any operation and `allow_export` was always its inverse. Released as a minor by decision rather than carrying dead fields through a deprecation cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated against RoboFinSystems/robosystems#refactor/backup-drop-encryption-flag, which retires the backup
encryptionflag.The flag never encrypted anything at the application layer — it only suppressed downloads, and because it defaulted to
false, the default backup was unrestorable. Restore is now gated on graph type instead, and every completed backup is downloadable. Objects remain encrypted at rest with S3 SSE-AES256 and are served over TLS through short-lived signed URLs.Contract changes
BackupListResponserestore_supported: bool | Unset = TrueBackupCreateRequestencryptionBackupResponseencryption_enabled,allow_exportrestore_supportedis false for entity graphs (materialized from the extensions database — usematerialize) and for shared repositories (platform-managed, download-only).Also picks up description edits in
get_backup_download_urlandrestore_backup.Versioning
Intended as a minor. Removing response fields breaks a consumer that reads them, which strict semver would call a major — but nothing reads them: the flag has no effect on any operation and
allow_exportwas always its inverse. Called deliberately rather than carrying dead fields through a deprecation cycle.An earlier regen widened
encryption_enabledandallow_exportfrombooltobool | Unset— that would have been a genuine breaking read. Fixed upstream before this regen; the diff here is pure removals plus the one addition.REST-only change, so
schema.graphqlis untouched and the codegen drift gate is unaffected.Verification
just test-all— 519 passed, 17 skipped; ruff, ruff format, basedpyright all clean.Merge after the upstream API PR.