Conversation
jvogt23
requested changes
Feb 21, 2026
elysseaa
reviewed
Feb 21, 2026
elysseaa
left a comment
elysseaa
left a comment
Collaborator
There was a problem hiding this comment.
I generally agree with James' feedback - I think he got most of the issues down. I also had one minor question about the .gitignore file, but it's not as important.
jvogt23
reviewed
Apr 18, 2026
jvogt23
left a comment
jvogt23
left a comment
Collaborator
There was a problem hiding this comment.
Final comment, saw nothing else that needed attention
| title: React.ReactNode; | ||
| itemKey: (item: T, index: number) => string; | ||
| callout?: React.ReactNode; | ||
| preItem?: (index: number) => React.ReactNode; |
Collaborator
There was a problem hiding this comment.
In the last meeting, did we consider preItem and postItem unnecessary? If so we should remove this
jvogt23
requested changes
Apr 25, 2026
jvogt23
reviewed
Apr 25, 2026
jvogt23
left a comment
jvogt23
left a comment
Collaborator
There was a problem hiding this comment.
Just comment out the demo and we're good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a basic ItemList Component that copied the one in the Android app and left an example in the merchandise screen.