Skip to content

add aerostack packages in linux64#388

Merged
traversaro merged 1 commit into
RoboStack:mainfrom
mebbaid:aerostack2
Feb 24, 2026
Merged

add aerostack packages in linux64#388
traversaro merged 1 commit into
RoboStack:mainfrom
mebbaid:aerostack2

Conversation

@mebbaid
Copy link
Copy Markdown
Contributor

@mebbaid mebbaid commented Feb 22, 2026

This is a draft adding aerostack2 packages on linux64.

Surprisingly, the CI fails even If I am able to build locally in my machine.

@mebbaid
Copy link
Copy Markdown
Contributor Author

mebbaid commented Feb 23, 2026

Even remotely against my fork mebbaid#2 the ci passes. I am a bit puzzled.

@traversaro
Copy link
Copy Markdown
Member

Even remotely against my fork mebbaid#2 the ci passes. I am a bit puzzled.

Probably you have an old Github Action cache in the PR (and that is why your remote PR does not see the cache of this PR). You can use true in https://github.com/mebbaid/ros-humble/blob/aerostack2/.github/workflows/testpr.yml#L10 to ignore the cache and always to a rebuild of the packages built in the PR.

@mebbaid
Copy link
Copy Markdown
Contributor Author

mebbaid commented Feb 23, 2026

The CI now passes. But it is tedious and does not seem to be the "correct" way of doing it. I had to patch all downstream packages of as2_core to epxlicitly require find_package(GeographicLib). Ideally, it should be only a single patch of the as2_core CMakeLists to make the dependency transitive. But not sure why that didn't work.
I will investigate further.

@Tobias-Fischer Tobias-Fischer marked this pull request as ready for review February 23, 2026 19:19
@mebbaid
Copy link
Copy Markdown
Contributor Author

mebbaid commented Feb 24, 2026

Ok, seemed that my issue was two-fold. I was mixing plain sig and keywords when invoking target_link_libs in my cmakelists for geographic lib on the as2_core original patch. I also needed to patch the package.xml of the as2_core. with that, we should not need all the downstream packages as2-* patches.

I will clean up with one last commit and then should be good to go.

patch as2-core

fix corrupt as2_core patch file

add patch for as2_behavior_perception

make geolib public to downstream users

make geolib public to users of as2_core

disable ga action cache during ci

remove as2_core patch, patch all downstream-packages to find geographic lib

re-enable cache in ci workflow

make geolib transitive dep via as2-core patch, remove unnecessary patches
Copy link
Copy Markdown
Contributor

@Tobias-Fischer Tobias-Fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - just a note that in RoboStack the changes in your package.xml do not actually apply because of the way we invoke vinca, but still good to add.

@traversaro
Copy link
Copy Markdown
Member

Thanks @mebbaid !

@traversaro traversaro merged commit 1805017 into RoboStack:main Feb 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants