fix(ui-core): vocabulary pass layer 1 + rename the Versions tab (#292) - #298
Merged
Conversation
JArmandoAnaya
enabled auto-merge (squash)
August 4, 2026 04:20
… tab says what it holds (#292) Label strings only. The batch table finally uses batchStateLabel — the helper sat thirty lines away while the table showed in_annotation raw; the ingest run and failure badges get the same treatment with the same fall-through-to-raw convention; the asset-progress label map existed twice and the AnnotationPage copy is gone, the gallery's casing winning; the Versions tab is labelled Schema history because it holds schema versions while releases live on the Dataset screen — the union value, testid and ?tab=versions are public API and do not move; and the schema diff badges are sentence-cased while change.detail stays verbatim, since it must remain the kernel's own sentence.
JArmandoAnaya
force-pushed
the
journey/pr5-vocab
branch
from
August 4, 2026 04:21
97d2fb5 to
247818e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #292. Stacked on #297 (
journey/pr4-approve) — merge order #294 → #295 → #296 → #297 → this.What — label strings only, worst-first
BatchesScreenstate badge rendersbatchStateLabel(batch.state)— the helper sat thirty lines away inbatchState.tswhile the table showed rawin_annotation. Visible change:draft→ "pending approval",in_annotation→ "in progress" (the gallery header already said both).IngestScreen: run badge getsRUN_STATE_LABEL(pending → "Waiting", running → "Processing", completed → "Done", failed → "Failed"); failure-table kind badge getsFAILURE_KIND_LABEL(unsupported → "Unsupported format", corrupt → "Corrupt file"). Both followbatchState.ts's convention — an unknown member falls through to itself, so a newer server's state reads as that state rather than as a shrug. The "N corrupt / N unsupported" count badges keep their wording.AnnotationPage.tsxkept a second copy of the five-state map; it now importsPROGRESS_LABELfrombatchState.ts. The gallery's lowercase casing wins (majority spelling and the house style for state badges), so the annotator badge reads "skipped"/"unannotated"/"in review" instead of "Skipped"/"Unannotated".TAB_LABELSonly): the tab holds schema versions while releases live on the Dataset screen. TheProjectTabunion value, testid, and?tab=versionsare public API and do not move. The tab's descriptive prose now says "Every schema version…".change.detailstays verbatim (same-sentence rule with the kernel's refusals).Out of scope, by design: promote/partition/trunk/manifest copy, error-codes-as-headings, the Dataset & Releases merge — all #293, discussion first.
Every test assertion touched (same commit as its string)
frontend/ui-core/src/screens/screens.test.tsx:976-993— the two exact tab-label lists ("Versions" → "Schema history").frontend/ui-core/src/screens/screens.test.tsx:591-592— diff badges ("destructive"/"additive" → sentence case).frontend/ui-core/src/screens/ingest.test.tsx:683— run badge ("completed" → "Done").frontend/app/e2e/annotate.spec.ts:311, :330, :357— asset-progress badge follows the consolidated lowercase map.frontend/app/cycle/cycle.spec.ts:172, :242, :252— run badge "Done", batch row "pending approval", state badge "in progress".Runs
bash scripts/check.sh frontend: All checks passed (ui-core 397 tests / 27 files).annotate.spec.ts gallery.spec.ts navigation.spec.ts shell.spec.ts: 71 passed.pnpm cycle(the full cycle against a real server): 1 passed — the suite that pins all three batch-table strings.