Optimize CI coverage across Node.js and ROS 2 - #1592
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The current change removes Windows CI coverage for Node.js 24 while adding 22, which likely contradicts the intent to add coverage rather than replace it.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the Windows GitHub Actions CI workflow to run against Node.js 22, aligning Windows test coverage with the project’s Node.js support requirements in issue #1591.
Changes:
- Switch Windows CI Node.js version matrix from
24.Xto22.X.
File summaries
| File | Description |
|---|---|
| .github/workflows/windows-build-and-test.yml | Updates the Node.js version used in the Windows CI matrix to target Node.js 22. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
16
to
18
| matrix: | ||
| node-version: [24.X] | ||
| node-version: [22.X] | ||
| ros_distribution: |
|
coverage: 90.878% (-0.2%) from 91.067% — minggangw:fix-1591 into RobotWebTools:develop |
minggangw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1591