Support custom resolutions properly#242
Conversation
mvollrath
left a comment
mvollrath
left a comment
There was a problem hiding this comment.
Should the build/ changes be in this PR?
| this.pointSize = options.pointSize || 3; | ||
| this.width = options.width || 1024; | ||
| this.height = options.height || 1024; | ||
| this.resolutionFactor = Math.max(this.width, this.height) / 1024; |
There was a problem hiding this comment.
Is there something special about 1024 besides being the default height/width? Should this be max / min instead of max / 1024?
There was a problem hiding this comment.
Should this be max / min instead of max / 1024?
No. It should be a ratio of the default 1024 resolution. The max is just for completeness, we can use either the width or height, since the encoded image is always square.
It's good to update the build files for CDN purposes every once in a while. As long as that's in a separate commit I don't see an issue with it. |
|
The built files in this PR don't load due to mrdoob/three.js#12719 |
viktorku
force-pushed
the
support-custom-resolutions-properly
branch
from
a6bdfdf to
27dbf62
Compare
|
I removed the build. I'll merge this in as it doesn't break anything. Confirmed it's working fine. |
2 participants
Adds/computes a
resolutionFactorfrom the resolution of the encoded depthcloud image that needs to be applied for the pose of each point in the vertex shader. It only needs to be applied in X and Y, otherwise the pointcloud appearsresolutionFactorsmaller.Discovered when using a custom resolution/cropsize with RobotWebTools/depthcloud_encoder#11