Skip to content

interactivemarkers: get the correct transformation for sub-markers#72

Merged
rctoris merged 2 commits intoRobotWebTools:developfrom
T045T:interactive_marker_submarker_pose
Aug 6, 2014
Merged

interactivemarkers: get the correct transformation for sub-markers#72
rctoris merged 2 commits intoRobotWebTools:developfrom
T045T:interactive_marker_submarker_pose

Conversation

@T045T
Copy link
Contributor

@T045T T045T commented Jul 18, 2014

tested with http://www.cse.wustl.edu/~dvl1/stuff/marker_marker_marker_frame_bug.zip - submarker now shows up where you'd expect it to
also made sure examples/interactivemarkers.html still works

RE: #71 - ros3djs now mirrors RViz, but it's unclear if thats ultimately the desired behavior

tested with http://www.cse.wustl.edu/~dvl1/stuff/marker_marker_marker_frame_bug.zip - submarker now shows up where you'd expect it to
also made sure examples/interactivemarkers.html still works
@DLu
Copy link
Contributor

DLu commented Jul 23, 2014

This version doesn't seem to work on a more complex example. I'm working on narrowing in to find the exact cause now.

@DLu
Copy link
Contributor

DLu commented Jul 23, 2014

In the above example, rviz shows the marker at 1m when the IM header is /up or /world.

Using the standard version of ros3djs, it appears at 0m and 1m for /world and /up respectively.

With this version of ros3djs, it appears at 1m and 2m for /world and /up respectively.

@T045T
Copy link
Contributor Author

T045T commented Jul 24, 2014

updated the pull request - together with RobotWebTools/tf2_web_republisher#14, I believe it works correctly now.

@DLu
Copy link
Contributor

DLu commented Jul 24, 2014

Works for me in both the toy example and my more complex example. Thanks for the fix!

@DLu
Copy link
Contributor

DLu commented Aug 4, 2014

Any reason not to merge this?

@rctoris
Copy link
Contributor

rctoris commented Aug 4, 2014

I haven't had time to test this yet, if you can confirm https://github.com/RobotWebTools/ros3djs/blob/develop/examples/interactivemarkers.html works as expected I can go ahead and merge!

rctoris added a commit that referenced this pull request Aug 6, 2014
interactivemarkers: get the correct transformation for sub-markers
@rctoris rctoris merged commit c6b6343 into RobotWebTools:develop Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants