MarkerClient: Subscribe to MarkerArray topic#74
MarkerClient: Subscribe to MarkerArray topic#74rctoris merged 4 commits intoRobotWebTools:developfrom
Conversation
MarkerClient will now automatically subscribe to the topic provided in the constructor, *and* <topicname>_array
|
Would it make more sense for this to live in its own object type? e.g., MarkerArrayClient. Currently, this will subscribe to both a marker and marker array topic on the same client, when one or the other might not even exist. |
|
It would be simple enough to make a MarkerArrayClient, but the RViz Marker Plugin also subscribes to both the regular and the |
|
Good point :) I've moved the functionality into |
|
Looks good! 🍰 |
MarkerClient: Subscribe to MarkerArray topic
|
Thanks @T045T ! |
There was a problem hiding this comment.
Should this line be
ROS3D.MarkerArrayClient.prototype.__proto__ = EventEmitter2.prototype;
?
I'm currently getting
Uncaught TypeError: Cannot read property 'prototype' of undefined
on this line.
There was a problem hiding this comment.
Yes, of course. It's fixed now, sorry about that.

Fixes #73