Skip to content

Conversation

@EzraBrooks
Copy link
Collaborator

another simple one, and yet again with typos in the timestamp field names :rage2:

@EzraBrooks EzraBrooks merged commit a6f8b86 into develop Nov 7, 2025
3 checks passed
@EzraBrooks EzraBrooks deleted the port-goal-to-typescript branch November 7, 2025 01:13
@sea-bass
Copy link
Contributor

sea-bass commented Nov 7, 2025

so fun fact, it seems like the stamp fields changed from secs to sec between ros 1 and 2, because rosbridge seems to accept them both?

https://github.com/RobotWebTools/rosbridge_suite/blob/7426843a88b2bf4795fb653daa6e6a5e1f9cbf8b/rosbridge_library/src/rosbridge_library/internal/message_conversion.py#L422-L430

@EzraBrooks
Copy link
Collaborator Author

what.. but the documentation for ros::time has sec and nsec

@EzraBrooks
Copy link
Collaborator Author

oh lord..

https://design.ros2.org/articles/changes.html

In ROS 1 the duration and time types are defined in the client libraries. The member names of the data structures are different in C++ (sec, nsec) and Python (secs, nsecs).

well, good thing rosbridge rectifies them.

@EzraBrooks
Copy link
Collaborator Author

I'm gonna

in my next PR. I want roslibjs to be internally consistent even if that means using the ros1 stuff for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants