fix(ros2): slash-normalize available names in entity waiters#801
Merged
maciejmajek merged 1 commit intoJul 22, 2026
Merged
Conversation
Compare requested and discovered services/topics/actions after ensure_slash so ROS graph names without a leading slash do not leave waiters missing and false-timeout. Cover no-slash discovery and negative timeout.
maciejmajek
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
wait_for_ros2_*helpers slash-normalize requested names but compared them to raw discovery names. If the graph lists services/topics/actions without a leading/, waiters treat them as missing and can false-timeout whentimeout > 0.Proposed Changes
get_missing_entities, normalize both requested and available withensure_slash.ValueError.Testing
tests/communication/ros2/test_waiters.pyextensions (monkeypatched DummyConnector; no live ROS).specs/rai/2026-07-14-2.md.Duplicate check
No open PR for waiter slash normalization of available entities.