fix(agents): reject non-positive LangChainAgent max_size#815
Merged
maciejmajek merged 2 commits intoJul 22, 2026
Merged
Conversation
Refuse max_size <= 0 so the message buffer cannot be constructed in a state where every enqueue immediately treats the queue as full.
maciejmajek
approved these changes
Jul 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bartok9/fixes #815 +/- ##
=================================================
+ Coverage 73.19% 73.99% +0.79%
=================================================
Files 82 82
Lines 3582 3584 +2
=================================================
+ Hits 2622 2652 +30
+ Misses 960 932 -28 ☔ View full report in Codecov by Harness. |
Require-version-bump gates src/rai_core changes; drop extra blank after pytest import (ruff).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LangChainAgenttreated anymax_sizeas valid. Withmax_size <= 0, the queue is always considered full on the first enqueue path (len >= max_size), so the agent either drops/poplefts incorrectly or never buffers usefully.Change
ValueErrorwhenmax_size <= 0at construction.Test plan
uv run python -m pytest tests/agents/langchain/test_langchain_agent_max_size.py -qAI-assisted; human-reviewed.