Skip to content

refactor: Chat endpoints to use AJV schemas#35210

Merged
kodiakhq[bot] merged 6 commits intodevelopfrom
refactor/chat-ajv
Feb 17, 2025
Merged

refactor: Chat endpoints to use AJV schemas#35210
kodiakhq[bot] merged 6 commits intodevelopfrom
refactor/chat-ajv

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Feb 14, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-293

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 14, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 11e3954

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (d4f6aa1) to head (11e3954).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35210   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2827     2827           
  Lines        68162    68162           
  Branches     15123    15123           
========================================
  Hits         40516    40516           
  Misses       24990    24990           
  Partials      2656     2656           
Flag Coverage Δ
unit 75.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review February 17, 2025 16:15
@KevLehman KevLehman requested review from a team as code owners February 17, 2025 16:15
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Feb 17, 2025
@KevLehman
Copy link
Member Author

/bark

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 17, 2025

woof

@KevLehman KevLehman added this to the 7.4.0 milestone Feb 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 17, 2025
@kodiakhq kodiakhq bot merged commit 25de597 into develop Feb 17, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the refactor/chat-ajv branch February 17, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants