Skip to content

chore: accept ReactNode as toast message#35537

Merged
ggazzo merged 3 commits intodevelopfrom
feat/toastmessage
Mar 17, 2025
Merged

chore: accept ReactNode as toast message#35537
ggazzo merged 3 commits intodevelopfrom
feat/toastmessage

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Mar 17, 2025

ARCH-1471

Proposed changes (including videos or screenshots)

when using useToastMessageDispatch, you can now pass a ReactNode as the message on the payload

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025

⚠️ No Changeset found

Latest commit: ea256b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliajforesti juliajforesti marked this pull request as ready for review March 17, 2025 18:33
@juliajforesti juliajforesti requested a review from a team as a code owner March 17, 2025 18:33
@juliajforesti juliajforesti added this to the 7.5.0 milestone Mar 17, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35537/

Built to branch gh-pages at 2025-03-17 19:20 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (02b3de6) to head (5e50d52).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35537      +/-   ##
===========================================
- Coverage    59.66%   59.66%   -0.01%     
===========================================
  Files         2827     2827              
  Lines        68370    68369       -1     
  Branches     15143    15143              
===========================================
- Hits         40794    40793       -1     
  Misses       24962    24962              
  Partials      2614     2614              
Flag Coverage Δ
unit 75.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Mar 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 17, 2025
@ggazzo ggazzo merged commit aa7b6a4 into develop Mar 17, 2025
5 of 6 checks passed
@ggazzo ggazzo deleted the feat/toastmessage branch March 17, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants