Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented May 20, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1172

Steps to test or reproduce

Further comments

Before:

"find": "rocketchat_room",
    "filter": {
        "_id": "fymuyGD35c5ASMazo"
"fname": {}
    },

After

"find": "rocketchat_room",
    "filter": {
        "_id": "fymuyGD35c5ASMazo"
"fname": "1235/ig"
    },

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 20, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.7.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2025

⚠️ No Changeset found

Latest commit: 52b8bc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36042/

Built to branch gh-pages at 2025-05-21 20:06 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.91%. Comparing base (aaf62dc) to head (52b8bc4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36042   +/-   ##
========================================
  Coverage    64.91%   64.91%           
========================================
  Files         3110     3110           
  Lines        93605    93605           
  Branches     17788    17788           
========================================
+ Hits         60760    60763    +3     
- Misses       30055    30056    +1     
+ Partials      2790     2786    -4     
Flag Coverage Δ
e2e 58.41% <ø> (ø)
unit 71.58% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman marked this pull request as ready for review May 20, 2025 20:33
@KevLehman KevLehman requested a review from sampaiodiego May 21, 2025 15:55
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label May 21, 2025
@sampaiodiego sampaiodiego added this to the 7.7.0 milestone May 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 21, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 21, 2025
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label May 22, 2025
@kodiakhq kodiakhq bot merged commit a70075e into develop May 22, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the fix/regexp-trace branch May 22, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants