refactor: remove computation from LegacyRoomManager#36135
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36135 +/- ##
===========================================
- Coverage 64.79% 64.79% -0.01%
===========================================
Files 3153 3153
Lines 104876 104859 -17
Branches 19985 20019 +34
===========================================
- Hits 67955 67943 -12
+ Misses 34242 34228 -14
- Partials 2679 2688 +9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
63981a0 to
7a83ab2
Compare
e36af0a to
67fee8c
Compare
67fee8c to
0b1f93f
Compare
…placing UnreadSince class with direct Date handling and introducing new listener functions
7965260 to
9d2c4d7
Compare
…ctive in LegacyRoomManager
…ening logic in LegacyRoomManager
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
https://rocketchat.atlassian.net/browse/ARCH-1684
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments