Skip to content

test: Automate the functionality for quoting an attachment with description.#36190

Merged
kodiakhq[bot] merged 7 commits intodevelopfrom
quote-attachment
Jun 23, 2025
Merged

test: Automate the functionality for quoting an attachment with description.#36190
kodiakhq[bot] merged 7 commits intodevelopfrom
quote-attachment

Conversation

@Harmeet221
Copy link
Contributor

@Harmeet221 Harmeet221 commented Jun 10, 2025

JIRA TASK: https://rocketchat.atlassian.net/browse/QA-81

Test 1: should show file preview and description when quoting a message with attachment in the channel
Steps:

Send message with attachment in the channel
Quote the message with attachment
Verify the quoted message appears correctly
Test 2: Should quote attachment file within a thread
Steps:
Send initial message in channel
Create thread and send message with attachment
Quote the message with attachment in thread
Verify the quoted message appears correctly in thread
Test3: should quote the link message
Steps:
Send link message in channel
Quote the link message
Verify the quoted link message appears correctly

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@Harmeet221 Harmeet221 requested a review from a team as a code owner June 10, 2025 12:11
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 10, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2025

⚠️ No Changeset found

Latest commit: 07070ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Harmeet221 Harmeet221 marked this pull request as draft June 10, 2025 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36190/

Built to branch gh-pages at 2025-06-23 14:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.83%. Comparing base (61b77e4) to head (07070ea).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36190      +/-   ##
===========================================
+ Coverage    64.80%   64.83%   +0.02%     
===========================================
  Files         3153     3153              
  Lines       104789   104789              
  Branches     19956    20017      +61     
===========================================
+ Hits         67908    67937      +29     
+ Misses       34193    34161      -32     
- Partials      2688     2691       +3     
Flag Coverage Δ
e2e 57.66% <ø> (+0.09%) ⬆️
unit 69.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Harmeet221 Harmeet221 marked this pull request as ready for review June 16, 2025 09:05
@aleksandernsilva aleksandernsilva added this to the 7.9.0 milestone Jun 23, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Jun 23, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2025
@kodiakhq kodiakhq bot merged commit 44d87dd into develop Jun 23, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the quote-attachment branch June 23, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants