fix: `UserAutoCompleteMultiple` not considering `UI_Use_Real_name` setting by dougfabris · Pull Request #38299 · RocketChat/Rocket.Chat

dougfabris · 2026-01-22T21:12:41Z

Proposed changes (including videos or screenshots)

Currently the component isn't considering the setting so having it enabled or disabled doesn't have any impact in the component. It aims to change it properly based on the setting.

The screenshots below displays how it works with the setting enabled and disabled:

Enabled

Disabled

Issue(s)

Steps to test or reproduce

Further comments

CORE-1780

Summary by CodeRabbit

New Features
- Enhanced user display in autocomplete and chip components: when "Use Real Name" is enabled, real names are now displayed, with usernames shown for non-federated users.
Tests
- Added test coverage for real name display functionality.

…nents

changeset-bot · 2026-01-22T21:12:46Z

⚠️ No Changeset found

Latest commit: ca03e87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-01-22T21:12:49Z

Walkthrough

This PR updates UserAutoComplete components to respect the UI_Use_Real_Name setting by implementing display logic that shows user real names when enabled, with usernames displayed inline for non-federated users. Changes span the option display component, avatar chip component, and includes a test case validating the new functionality.

Changes

Cohort / File(s)	Summary
UI_Use_Real_Name Support `apps/meteor/client/components/UserAutoCompleteMultiple/UserAutoCompleteMultipleOption.tsx`, `apps/meteor/client/components/UserAutoCompleteMultiple/UserAvatarChip.tsx`	Implements conditional display logic using useSetting('UI_Use_Real_Name') and useUserDisplayName hook to show real names when enabled, replacing previous inline username-only display.
Tests `apps/meteor/client/components/UserAutoCompleteMultiple/UserAvatarChip.spec.tsx`	Adds test case validating that real name displays correctly when UI_Use_Real_Name setting is enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

fix: User Autocomplete's avatar being misaligned #37486 — Introduces the UserAvatarChip component that this PR extends with useUserDisplayName hook integration.
chore: bump fuselage package #37699 — Also modifies UserAutoCompleteMultipleOption.tsx to change option label handling and display logic.
test: replace data-qa attributes for Autocomplete locators #38029 — Modifies UserAutoCompleteMultipleOption rendering with changes to Option element's label and aria attributes.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

juliajforesti
ggazzo
gabriellsh

Poem

🐰 With whiskers twitched and nose held high,
We celebrate real names on display!
No more usernames by and by,
When settings say the proper way—
A UI that respects each soul's true name,
Our fuzzy hearts rejoice all the same! 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main fix: UserAutoCompleteMultiple now respects the UI_Use_Real_name setting, which matches the core changes across all modified files.
Linked Issues check	✅ Passed	The PR fully addresses CORE-1780 by implementing conditional display logic in UserAutoCompleteMultiple components that respects the UI_Use_Real_name setting as required.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing UI_Use_Real_name support in UserAutoCompleteMultiple components; no unrelated modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/UserAutoCompleteMultiple-displayName

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

dionisio-bot · 2026-01-22T21:12:50Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is targeting the wrong base branch. It should target 8.2.0, but it targets 8.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

github-actions · 2026-01-22T21:30:24Z

📦 Docker Image Size Report

➡️ Changes

Service	Current	Baseline	Change
sum of all images	0B	0B	0B
account-service	0B	0B	0B
authorization-service	0B	0B	0B
ddp-streamer-service	0B	0B	0B
omnichannel-transcript-service	0B	0B	0B
presence-service	0B	0B	0B
queue-worker-service	0B	0B	0B
rocketchat	0B	0B	0B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/05 03:43 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.4GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 0B

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-38299
Baseline: develop
Timestamp: 2026-02-05 03:43:30 UTC
Historical data points: 30

Updated: Thu, 05 Feb 2026 03:43:31 GMT

codecov · 2026-01-22T21:52:58Z

Codecov Report

❌ Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.37%. Comparing base (5b5082f) to head (ca03e87).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38299      +/-   ##
===========================================
- Coverage    70.40%   70.37%   -0.04%     
===========================================
  Files         3161     3161              
  Lines       110639   110653      +14     
  Branches     19870    20091     +221     
===========================================
- Hits         77895    77870      -25     
- Misses       30717    30754      +37     
- Partials      2027     2029       +2

Flag	Coverage Δ
e2e	`60.35% <57.14%> (-0.03%)`	⬇️
e2e-api	`47.83% <ø> (-0.05%)`	⬇️
unit	`71.36% <25.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cubic-dev-ai

No issues found across 4 files

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@apps/meteor/client/components/UserAutoCompleteMultiple/UserAutoCompleteMultipleOption.tsx`:
- Around line 18-39: Compute a plain-text label that matches the rendered option
and use it for aria-label: create a labelText (e.g., in the same scope as
useMemo) that follows the same logic as optionLabel (if !useRealName || !name ->
username; otherwise -> `${name} (${username})`) and account for _federated the
same way optionLabel does, then replace aria-label={username} with
aria-label={labelText}. Ensure you reference useRealName, name, username,
_federated and optionLabel logic so the screen-reader text exactly matches the
visible label.

apps/meteor/client/components/UserAutoCompleteMultiple/UserAutoCompleteMultipleOption.tsx

fix: update user display name logic in UserAutoCompleteMultiple compo…

c8332a7

…nents

dougfabris added this to the 8.2.0 milestone Jan 22, 2026

test: add and update unit test

a666b72

dougfabris marked this pull request as ready for review February 4, 2026 21:11

dougfabris requested a review from a team as a code owner February 4, 2026 21:11

cubic-dev-ai bot reviewed Feb 4, 2026

View reviewed changes

coderabbitai bot reviewed Feb 4, 2026

View reviewed changes

apps/meteor/client/components/UserAutoCompleteMultiple/UserAutoCompleteMultipleOption.tsx Show resolved Hide resolved

yash-rajpal approved these changes Feb 4, 2026

View reviewed changes

tassoevan requested changes Feb 4, 2026

View reviewed changes

apps/meteor/client/components/UserAutoCompleteMultiple/UserAutoCompleteMultipleOption.tsx Show resolved Hide resolved

tassoevan approved these changes Feb 5, 2026

View reviewed changes

tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Feb 5, 2026

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 5, 2026

Merge branch 'develop' into fix/UserAutoCompleteMultiple-displayName

ca03e87

kodiakhq bot merged commit aaec97f into develop Feb 5, 2026
44 checks passed

kodiakhq bot deleted the fix/UserAutoCompleteMultiple-displayName branch February 5, 2026 04:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: `UserAutoCompleteMultiple` not considering `UI_Use_Real_name` setting#38299

fix: `UserAutoCompleteMultiple` not considering `UI_Use_Real_name` setting#38299
kodiakhq[bot] merged 3 commits intodevelopfrom
fix/UserAutoCompleteMultiple-displayName

dougfabris commented Jan 22, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

dionisio-bot bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dougfabris commented Jan 22, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Enabled

Disabled

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

dionisio-bot bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

➡️ Changes

📊 Historical Trend

Uh oh!

codecov bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dougfabris commented Jan 22, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jan 22, 2026 •

edited

Loading

coderabbitai bot commented Jan 22, 2026 •

edited

Loading

dionisio-bot bot commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

codecov bot commented Jan 22, 2026 •

edited

Loading