chore: export ConnectionStatus type from @rocket.chat/ddp-client#41347
chore: export ConnectionStatus type from @rocket.chat/ddp-client#41347Rohit3523 wants to merge 2 commits into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
WalkthroughThe DDP client exports its ChangesDDP Client Public Type
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41347 +/- ##
========================================
Coverage 68.69% 68.70%
========================================
Files 4139 4139
Lines 159112 159112
Branches 27917 27898 -19
========================================
+ Hits 109300 109314 +14
+ Misses 44666 44656 -10
+ Partials 5146 5142 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
9bae4b4 to
d3a645c
Compare
Proposed changes (including videos or screenshots)
ConnectionStatuswas declared as a privatetypeinsidepackages/ddp-client/src/Connection.tsand never exported, forcing consumers to repeat the union inline. This PR exports it and re-exports it from the package entry point so it can be imported directly:This gives us a single source of truth for the connection status union.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-2447
Steps to test or reproduce
ConnectionStatusfrom@rocket.chat/ddp-clientin a consumer and confirm the type resolves.Further comments
Additive public API export only (no behavior change). Follow-up: migrate any inline duplicates of this union to import the exported type.
Summary by CodeRabbit
ConnectionStatustype to the public DDP client package exports.