Skip to content

chore: export ConnectionStatus type from @rocket.chat/ddp-client#41347

Open
Rohit3523 wants to merge 2 commits into
developfrom
chore/export-connection-status-type
Open

chore: export ConnectionStatus type from @rocket.chat/ddp-client#41347
Rohit3523 wants to merge 2 commits into
developfrom
chore/export-connection-status-type

Conversation

@Rohit3523

@Rohit3523 Rohit3523 commented Jul 13, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

ConnectionStatus was declared as a private type inside packages/ddp-client/src/Connection.ts and never exported, forcing consumers to repeat the union inline. This PR exports it and re-exports it from the package entry point so it can be imported directly:

import type { ConnectionStatus } from '@rocket.chat/ddp-client';

This gives us a single source of truth for the connection status union.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-2447

Steps to test or reproduce

  • Import ConnectionStatus from @rocket.chat/ddp-client in a consumer and confirm the type resolves.

Further comments

Additive public API export only (no behavior change). Follow-up: migrate any inline duplicates of this union to import the exported type.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Added the ConnectionStatus type to the public DDP client package exports.
    • External integrations can now import and reuse the connection status type directly.

@dionisio-bot

dionisio-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@CLAassistant

CLAassistant commented Jul 13, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The DDP client exports its ConnectionStatus union through the package entry point and adds a minor-release changeset documenting the new public type.

Changes

DDP Client Public Type

Layer / File(s) Summary
Public ConnectionStatus export
packages/ddp-client/src/Connection.ts, packages/ddp-client/src/index.ts, .changeset/export-connection-status-type.md
Exports ConnectionStatus from its defining module, re-exports it from the package index, and documents a minor release.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: type: feature

Suggested reviewers: ggazzo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: exporting ConnectionStatus from @rocket.chat/ddp-client.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d3a645c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.70%. Comparing base (6dc66fb) to head (d3a645c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #41347   +/-   ##
========================================
  Coverage    68.69%   68.70%           
========================================
  Files         4139     4139           
  Lines       159112   159112           
  Branches     27917    27898   -19     
========================================
+ Hits        109300   109314   +14     
+ Misses       44666    44656   -10     
+ Partials      5146     5142    -4     
Flag Coverage Δ
e2e 58.84% <ø> (+0.01%) ⬆️
e2e-api 45.62% <ø> (+0.01%) ⬆️
unit 70.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rohit3523
Rohit3523 marked this pull request as ready for review July 20, 2026 15:40
@coderabbitai coderabbitai Bot added the type: feature Pull requests that introduces new feature label Jul 20, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

Comment thread .changeset/export-connection-status-type.md Outdated
@Rohit3523
Rohit3523 force-pushed the chore/export-connection-status-type branch from 9bae4b4 to d3a645c Compare July 25, 2026 12:53
@Rohit3523
Rohit3523 requested a review from juliajforesti July 25, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Pull requests that introduces new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants