chore: remove unused @rocket.chat/log-format package#41426
Conversation
The package (a copy of Meteor's logging formatter) was declared as a dependency of apps/meteor but never imported anywhere in the repo — no code references, no bin, no CI usage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Looks like this PR is ready to merge! 🎉 |
|
|
/jira ARCH-2200 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
WalkthroughThe ChangesLog-format package removal
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
KevLehman
left a comment
There was a problem hiding this comment.
approving cause I like the PR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41426 +/- ##
========================================
Coverage 68.47% 68.47%
========================================
Files 4092 4092
Lines 158285 158285
Branches 28622 28649 +27
========================================
+ Hits 108379 108385 +6
+ Misses 44874 44865 -9
- Partials 5032 5035 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Removes the
@rocket.chat/log-formatpackage, which is no longer used anywhere in the monorepo. The only remaining reference was the dependency entry inapps/meteor/package.json, with no imports of the package left in the codebase.packages/log-formatentirelyapps/meteor/package.jsonyarn.lockaccordinglyNo user-facing changes, so no changeset is needed.
Issue(s)
ARCH-2200
Steps to test or reproduce
yarn installcompletes successfully@rocket.chat/log-format— no references remainFurther comments
🤖 Generated with Claude Code
Task: ARCH-2264
Summary by CodeRabbit