Skip to content

chore: remove unused @rocket.chat/log-format package#41426

Merged
ggazzo merged 1 commit into
developfrom
chore/unused-log-format
Jul 17, 2026
Merged

chore: remove unused @rocket.chat/log-format package#41426
ggazzo merged 1 commit into
developfrom
chore/unused-log-format

Conversation

@tassoevan

@tassoevan tassoevan commented Jul 16, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Removes the @rocket.chat/log-format package, which is no longer used anywhere in the monorepo. The only remaining reference was the dependency entry in apps/meteor/package.json, with no imports of the package left in the codebase.

  • Deletes packages/log-format entirely
  • Drops the dependency from apps/meteor/package.json
  • Updates yarn.lock accordingly

No user-facing changes, so no changeset is needed.

Issue(s)

ARCH-2200

Steps to test or reproduce

  • yarn install completes successfully
  • Search the codebase for @rocket.chat/log-format — no references remain

Further comments

🤖 Generated with Claude Code

Task: ARCH-2264

Summary by CodeRabbit

  • Chores
    • Removed the legacy log-formatting package and its associated configuration.
    • Removed the package’s changelog and build metadata.
    • Eliminated the application dependency on the retired logging formatter.

The package (a copy of Meteor's logging formatter) was declared as a
dependency of apps/meteor but never imported anywhere in the repo —
no code references, no bin, no CI usage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@tassoevan tassoevan added this to the 8.7.0 milestone Jul 16, 2026
@dionisio-bot

dionisio-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b052497

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan

Copy link
Copy Markdown
Member Author

/jira ARCH-2200

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 464ec839-55ef-470e-a32e-e22f42db2788

📥 Commits

Reviewing files that changed from the base of the PR and between f96b66d and b052497.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (5)
  • apps/meteor/package.json
  • packages/log-format/CHANGELOG.md
  • packages/log-format/package.json
  • packages/log-format/src/index.ts
  • packages/log-format/tsconfig.json
💤 Files with no reviewable changes (5)
  • packages/log-format/CHANGELOG.md
  • packages/log-format/package.json
  • packages/log-format/tsconfig.json
  • packages/log-format/src/index.ts
  • apps/meteor/package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: Hacktron Security Check

Walkthrough

The @rocket.chat/log-format package implementation, configuration, metadata, and changelog were removed, along with its dependency declaration from the Meteor application.

Changes

Log-format package removal

Layer / File(s) Summary
Remove application dependency
apps/meteor/package.json
Removes @rocket.chat/log-format from the Meteor dependencies.
Delete package artifacts
packages/log-format/*
Removes the formatter implementation, package metadata, TypeScript configuration, and changelog.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing the unused @rocket.chat/log-format package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • ARCH-2200: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

@tassoevan
tassoevan requested a review from a team July 16, 2026 19:15

@KevLehman KevLehman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving cause I like the PR

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.47%. Comparing base (abab8a0) to head (b052497).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #41426   +/-   ##
========================================
  Coverage    68.47%   68.47%           
========================================
  Files         4092     4092           
  Lines       158285   158285           
  Branches     28622    28649   +27     
========================================
+ Hits        108379   108385    +6     
+ Misses       44874    44865    -9     
- Partials      5032     5035    +3     
Flag Coverage Δ
unit 70.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 16, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Jul 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 17, 2026
@tassoevan
tassoevan added this pull request to the merge queue Jul 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 17, 2026
@ggazzo
ggazzo merged commit 6d2c9f1 into develop Jul 17, 2026
85 of 88 checks passed
@ggazzo
ggazzo deleted the chore/unused-log-format branch July 17, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants