ci: pin synapse docker version - #41692
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (19)
🔇 Additional comments (1)
WalkthroughThe federation matrix test compose configuration pins the ChangesFederation matrix test environment
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41692 +/- ##
===========================================
+ Coverage 68.61% 68.65% +0.03%
===========================================
Files 4162 4162
Lines 158824 158824
Branches 28174 28157 -17
===========================================
+ Hits 108976 109034 +58
+ Misses 44665 44612 -53
+ Partials 5183 5178 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
The most recent Synapse version 1.158 launched today changed the default room version to 11 which we still don’t support, causing CI to fail since federation tests won’t pass because we only support room version 10.
So I'm pinning Synapse version to the previous version. We'll work on room version 11 later.
Issue(s)
CORE-2515
Steps to test or reproduce
Further comments
Summary by CodeRabbit