Skip to content

ci: pin synapse docker version - #41692

Merged
ggazzo merged 1 commit into
developfrom
ci-pin-synapse-version
Aug 4, 2026
Merged

ci: pin synapse docker version#41692
ggazzo merged 1 commit into
developfrom
ci-pin-synapse-version

Conversation

@sampaiodiego

@sampaiodiego sampaiodiego commented Aug 4, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

The most recent Synapse version 1.158 launched today changed the default room version to 11 which we still don’t support, causing CI to fail since federation tests won’t pass because we only support room version 10.

So I'm pinning Synapse version to the previous version. We'll work on room version 11 later.

Issue(s)

CORE-2515

Steps to test or reproduce

Further comments

Review in cubic

Summary by CodeRabbit

  • Chores
    • Pinned the Synapse service to a specific release version for more consistent test environments.

@dionisio-bot

dionisio-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 8.7.0, but it targets 8.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0420e88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e80720de-c89b-4dd4-bc16-1f70b408d445

📥 Commits

Reviewing files that changed from the base of the PR and between 9bf5285 and 0420e88.

📒 Files selected for processing (1)
  • ee/packages/federation-matrix/docker-compose.test.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (19)
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: Hacktron Security Check
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (2/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (4/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (3/5)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (1/5)
  • GitHub Check: 🔨 Test UI (CE) / MongoDB 8.0 (3/4)
  • GitHub Check: 🔨 Test UI (EE) / MongoDB 8.0 coverage (5/5)
  • GitHub Check: 🔨 Test API Apps (deno-runtime - EE) / MongoDB 8.0 coverage (1/1)
  • GitHub Check: 🔨 Test API Livechat (FIPS) / MongoDB 8.0 (1/1)
  • GitHub Check: 🔨 Test UI (CE) / MongoDB 8.0 (1/4)
  • GitHub Check: 🔨 Test UI (CE) / MongoDB 8.0 (2/4)
  • GitHub Check: 🔨 Test API Livechat (EE) / MongoDB 8.0 coverage (1/1)
  • GitHub Check: 🔨 Test UI (CE) / MongoDB 8.0 (4/4)
  • GitHub Check: 🔨 Test API (CE) / MongoDB 8.0 (1/1)
  • GitHub Check: 🔨 Test API (FIPS) / MongoDB 8.0 (1/1)
  • GitHub Check: 🔨 Test API Livechat (CE) / MongoDB 8.0 (1/1)
  • GitHub Check: 🔨 Test API (EE) / MongoDB 8.0 coverage (1/1)
  • GitHub Check: 🔨 Test Federation Matrix
🔇 Additional comments (1)
ee/packages/federation-matrix/docker-compose.test.yml (1)

44-44: LGTM!


Walkthrough

The federation matrix test compose configuration pins the hs1 Synapse service to version v1.157.2 instead of latest.

Changes

Federation matrix test environment

Layer / File(s) Summary
Pin Synapse test image
ee/packages/federation-matrix/docker-compose.test.yml
The hs1 service now uses Synapse image v1.157.2.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: type: chore

Suggested reviewers: ggazzo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: pinning the Synapse Docker image version for CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • CORE-2515: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sampaiodiego sampaiodiego added this to the 8.7.0 milestone Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.65%. Comparing base (9bf5285) to head (0420e88).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41692      +/-   ##
===========================================
+ Coverage    68.61%   68.65%   +0.03%     
===========================================
  Files         4162     4162              
  Lines       158824   158824              
  Branches     28174    28157      -17     
===========================================
+ Hits        108976   109034      +58     
+ Misses       44665    44612      -53     
+ Partials      5183     5178       -5     
Flag Coverage Δ
e2e 58.91% <ø> (+0.04%) ⬆️
e2e-api 45.98% <ø> (+0.25%) ⬆️
unit 70.53% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sampaiodiego
sampaiodiego marked this pull request as ready for review August 4, 2026 22:18

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 4, 2026
@ggazzo
ggazzo added this pull request to the merge queue Aug 4, 2026
Merged via the queue into develop with commit 4c37fbf Aug 4, 2026
56 checks passed
@ggazzo
ggazzo deleted the ci-pin-synapse-version branch August 4, 2026 23:46
sampaiodiego added a commit that referenced this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants