Skip to content

fix: downloadPublicImportFile doesn't use serverFetch with domain/IP validation checks - #41830

Merged
julio-rocketchat merged 3 commits into
release-8.6.2from
backport-8.6.2-41749
Aug 19, 2026
Merged

fix: downloadPublicImportFile doesn't use serverFetch with domain/IP validation checks#41830
julio-rocketchat merged 3 commits into
release-8.6.2from
backport-8.6.2-41749

Conversation

@dionisio-bot

@dionisio-bot dionisio-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Backport of #41749

Review in cubic

…validation checks (#41749)

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@dionisio-bot
dionisio-bot Bot requested a review from a team as a code owner August 18, 2026 16:34
@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: adbd801

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot

dionisio-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@julio-rocketchat
julio-rocketchat requested a review from a team as a code owner August 18, 2026 16:42
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.6.2@f1d512b). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-8.6.2   #41830   +/-   ##
================================================
  Coverage                 ?   70.06%           
================================================
  Files                    ?     3375           
  Lines                    ?   130893           
  Branches                 ?    22898           
================================================
  Hits                     ?    91712           
  Misses                   ?    35855           
  Partials                 ?     3326           
Flag Coverage Δ
e2e 59.49% <ø> (?)
e2e-api 46.19% <ø> (?)
unit 69.83% <83.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat
julio-rocketchat merged commit 39c1028 into release-8.6.2 Aug 19, 2026
289 of 304 checks passed
@julio-rocketchat
julio-rocketchat deleted the backport-8.6.2-41749 branch August 19, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Used to inform backported PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant