chore(fuselage,storybook): remove unsupported labelChildren control from CheckBox stories#2048
Merged
tassoevan merged 2 commits intoJul 3, 2026
Conversation
… stories
The CheckBox story exposed an auto-generated `labelChildren` control in
Storybook. Setting it to an object crashed Storybook with "Objects are not
valid as a React child (found: object with keys {})", since `labelChildren`
is a ReactNode rendered directly.
Disable the control via argTypes, mirroring the approach used for the `is`
prop. The component TypeScript definition is unchanged.
Closes RocketChat#1906
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
tassoevan
changed the title
tassoevan
approved these changes
Jul 3, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… stories
The CheckBox story exposed an auto-generated
labelChildrencontrol in Storybook. Setting it to an object crashed Storybook with "Objects are not valid as a React child (found: object with keys {})", sincelabelChildrenis a ReactNode rendered directly.Disable the control via argTypes, mirroring the approach used for the
isprop. The component TypeScript definition is unchanged.Closes #1906
Proposed changes (including videos or screenshots)
Issue(s)
Further comments