Implements the has_cached_role? method to prevent N+1 issues #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
gabrielhilal
force-pushed
the
has_cached_role
branch
2 times, most recently
from
b4a99c5 to
a9afe74
Compare
```ruby @user.add_role :admin, Forum @user.add_role :member, Forum users = User.with_role(:admin, Forum).preload(:roles) users.each do |user| user.has_cached_role?(:member, Forum) # no extra queries end ``` This method should be used with caution. If you don't preload the roles, the `has_cached_role?` might return `false`. In the above example, it would return `false` for `@user.has_cached_role?(:member, Forum)`, because `User.with_role(:admin, Forum)` will load only the `:admin` roles.
gabrielhilal
force-pushed
the
has_cached_role
branch
from
a9afe74 to
44db0cf
Compare
wldcordeiro
added a commit
that referenced
this pull request
Nov 6, 2015
Implements the has_cached_role? method to prevent N+1 issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method will take the preloaded roles and use ruby enumerable to check if user has the role without extra queries.
e.g: