Vent Critters post-factum changes#339
Merged
Merged
Conversation
Reworks clownspiders to not be such bastards, un-hardcodes ventcritterrulecomponent vars so we can set them per critter, increases the number of critters all around
|
Ideally the clown spider nerf would have been atomized into a separate, earlier PR; but since we agreed on this while coming up with the numbers, and the change is Just Good, we can get sloppy with this one. I'll review the file diff tomorrow. |
arenaconspiracy
approved these changes
Aug 13, 2025
arenaconspiracy
left a comment
There was a problem hiding this comment.
Diff looks good. Ingame test looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
Consensus seems to be that not enough creatures spawn during VentCritter events to be a real threat, especially since the event gives a clear warning as to the location of the spawn. These changes hope to increase the potential threat from the event without being overbearing. Many of the variables used to calculate how many creatures the event should spawn are no longer hard-coded, allowing us more control over the event. Given this, and the fact that slipping is no longer as much of a death sentence anymore, clown spiders have been re-enabled to add a bit more variety to the event. Given the relative strength of the clown spider compared to other mobs, their health was significantly decreased, and for now, the number of clown spiders that will spawn is significantly lower than other critter events. Hopefully this should make them much less frustrating opponents.
Technical details
Minor changes to C#, including the calculation for the count var in VentCrittersRule, and allowing many vars used by the accompanying component to be set by individual prototypes. Some changes to the yaml in pests.yml and events.yml
Media
Requirements
Breaking changes
Changelog
🆑