Guidebook Job ordering change#341
Conversation
github-actions
Bot
added
S: Untriaged
|
These are well meaning, albeit inconsequential, changes - Importantly, we require denoting changes to upstream files as changes made on our repository fall under a different license; however, since this is merely shifting lines & makes no "actual" "changes" it... falls in a legal grey area, as far as I would know. I need consensus from other maintainers. |
arenaconspiracy
added
S: Undergoing maintainer discussion
There was a problem hiding this comment.
Hello, and thank you for contributing.
A discussion may be made amongst other maintainers, however, as per policy, I would request that a new Jobs.xml be created under a _Ronstation folder (there is a guide in Ronstation discord on how you can do this). This was made to prevent merge conflicts whenever we update from upstream. shiftandcrew.yml do not require a new _Ronstation folder version, due to the modifications on an upstream file being necessary to effect those changes.
I would also really like that you add headers, as well as annotations, considering that Ronstation codebase is primarily AGPL-v3.0, and that any MIT-licensed file (such as upstream files) containing our modifications is subject to MIT sublicensed with AGPL. There is a guide also on Ronstation discord.
I hope that helps.
- Barnacle14.
|
When creating your new Jobs.xml, you'll also need to update the path for the jobs guide entry in shiftsandcrew.yml. The file you'll be looking for is Resources\Prototypes\Guidebook\shiftandcrew.yml. Just update the path to "_Ronstation/ServerInfo/Guidebook/Jobs.xml" |
|
Ok, annotated both the new Jobs.xml and shiftandcrew.yml and reverted the changes to the upstream Jobs.xml (or at least, should be reverted). |
|
imatsoup
left a comment
imatsoup
left a comment
There was a problem hiding this comment.
The order of jobs in the guidebook is ultimately arbitrary, but I don't see any harm in this
4 participants
About the PR
I reordered the list of jobs under the jobs in the guidebook to be alphabetical instead.
I also mentioned paramedics are a part of the medical department under the general jobs overview.
Why / Balance
The current ordering is rather arbitrary.
Paramedics are currently not mentioned in the general job overview.
No balance changes.
Technical details
All text changes.
Media
Requirements
Breaking changes
None.
Changelog