fix: exclude parallel_tool_calls for Bedrock models in LiteLLM · Pull Request #10235 · RooCodeInc/Roo-Code

ghost · 2025-12-20T19:36:25Z

Fixes the API error when using LiteLLM as a proxy to AWS Bedrock models.

Problem

Users were experiencing litellm.UnsupportedParamsError: bedrock does not support parameters: ['parallel_tool_calls'] when using LiteLLM to proxy requests to AWS Bedrock models. This is because Bedrock does not support the OpenAI-specific parallel_tool_calls parameter.

Solution

Added isBedrockModel() method to detect Bedrock models by checking for patterns like:
- Model IDs containing "bedrock"
- Model IDs starting with "anthropic.", "amazon.", or other AWS provider prefixes
- AWS Bedrock model ID patterns
Modified the request options to conditionally exclude parallel_tool_calls when routing to Bedrock models
Added comprehensive tests to verify the fix works for Bedrock models while maintaining existing behavior for other models

Testing

All existing tests pass ✅
Added 3 new test cases covering:
- Bedrock models excluding parallel_tool_calls
- Non-Bedrock models still including parallel_tool_calls
- Default behavior when parallelToolCalls is not specified

View task on Roo Code Cloud

Important

Fixes LiteLLM to exclude unsupported parallel_tool_calls for AWS Bedrock models by detecting model patterns and updating request handling.

Behavior:
- Adds isBedrockModel() in lite-llm.ts to detect Bedrock models by checking model ID patterns.
- Modifies createMessage() in lite-llm.ts to exclude parallel_tool_calls for Bedrock models.
Testing:
- Adds tests in lite-llm.spec.ts to verify exclusion of parallel_tool_calls for Bedrock models and inclusion for non-Bedrock models.
- Tests auto-detection and explicit configuration of Bedrock models.
UI:
- Adds litellmUseAzureBedrock checkbox in LiteLLM.tsx for user configuration.
- Updates settings.json with new UI text for Bedrock configuration.

^{This description was created by}^{for 5d474ee. You can customize this summary. It will automatically update as commits are pushed.}

ghost · 2025-12-20T19:36:35Z

Rooviewer See task on Roo Cloud

Review complete. Found 1 minor issue related to naming conventions.

Rename litellmUseAzureBedrock to litellmUseAwsBedrock or litellmUseBedrock (naming inconsistency: Azure vs AWS Bedrock)

Previous reviews

bbd325f: Review #1

157146a: Review #2

157146a: Review #3

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

ghost · 2025-12-20T20:02:55Z

Rooviewer See task on Roo Cloud

Review complete. No issues found.

The implementation correctly:

Adds isBedrockModel() method to detect Bedrock models via multiple patterns (including "bedrock", "anthropic.", "amazon.", and AWS provider prefixes)
Conditionally excludes parallel_tool_calls parameter for Bedrock models to fix the UnsupportedParamsError
Includes comprehensive test coverage for Bedrock models, non-Bedrock models, and default behavior

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

mrubens · 2025-12-20T20:43:20Z

+	 * Check if the model is routed through AWS Bedrock
+	 * Bedrock doesn't support the parallel_tool_calls parameter
+	 */
+	private isBedrockModel(modelId: string): boolean {


This doesn’t seem right

@roomote address this

Fixaroo See task on Roo Cloud

This issue was already addressed in commit bbd325f. The anthropic. prefix was removed from Bedrock detection to prevent false positives when users access Anthropic directly through LiteLLM. All tests pass.

_{View commit | Revert commit}

mrubens

Should we just add a checkbox/dropdown to the litellm provider about whether it’s bedrock? Maybe we want something like this for OpenAI compatible too so we can make sure to format the params correctly.

…ositives

hannesrudolph · 2025-12-21T23:45:04Z

Should we just add a checkbox/dropdown to the litellm provider about whether it’s bedrock? Maybe we want something like this for OpenAI compatible too so we can make sure to format the params correctly.

Yeah @roomote make it so

ghost · 2025-12-21T23:46:42Z

Fixaroo See task on Roo Cloud

Added a "Backend is AWS Bedrock" checkbox to the LiteLLM provider settings. This allows users to explicitly specify if their LiteLLM proxy routes to AWS Bedrock, instead of relying on auto-detection. All local checks passed.

_{View commit | Revert commit}

- Add litellmUseAzureBedrock option to provider settings schema - Add checkbox UI in LiteLLM settings to let users specify Bedrock backend - Update isBedrockModel() to use user-specified option over auto-detection - Add comprehensive tests for the new option - Add English translations for the new setting

ellipsis-dev · 2025-12-21T23:54:02Z

 		"getXaiApiKey": "Get xAI API Key",
 		"litellmApiKey": "LiteLLM API Key",
 		"litellmBaseUrl": "LiteLLM Base URL",
+		"litellmUseAzureBedrock": "Backend is AWS Bedrock",


Typographical note: The key litellmUseAzureBedrock mentions 'Azure' while the value and description refer to 'AWS Bedrock'. Please verify if the key should be renamed (e.g., to litellmUseAWSBedrock) to avoid confusion.

ghost · 2025-12-21T23:56:23Z

 	litellmApiKey: z.string().optional(),
 	litellmModelId: z.string().optional(),
 	litellmUsePromptCache: z.boolean().optional(),
+	litellmUseAzureBedrock: z.boolean().optional(),


Naming inconsistency: The property is named litellmUseAzureBedrock but it configures AWS Bedrock (Amazon), not Azure (Microsoft). This conflation of cloud providers in the variable name could confuse developers. Consider renaming to litellmUseAwsBedrock or litellmUseBedrock to match the actual functionality.

_{Fix it with Roo Code or mention @roomote and request a fix.}

fix: exclude parallel_tool_calls for Bedrock models in LiteLLM provider

157146a

github-project-automation Bot added this to Roo Code Roadmap and Roo Code Roadmap Dec 20, 2025

github-project-automation Bot moved this to Triage in Roo Code Roadmap Dec 20, 2025

github-project-automation Bot moved this to New in Roo Code Roadmap Dec 20, 2025

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 20, 2025

hannesrudolph marked this pull request as ready for review December 20, 2025 20:02

hannesrudolph requested review from cte, jr and mrubens as code owners December 20, 2025 20:02

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Dec 20, 2025

mrubens reviewed Dec 20, 2025

View reviewed changes

ghost mentioned this pull request Dec 20, 2025

fix: omit parallel_tool_calls from LiteLLM provider #10241

Closed

fix: exclude anthropic prefix from Bedrock detection to avoid false p…

bbd325f

…ositives

ellipsis-dev Bot reviewed Dec 21, 2025

View reviewed changes

ghost commented Dec 21, 2025

View reviewed changes

hannesrudolph closed this Dec 23, 2025

github-project-automation Bot moved this from New to Done in Roo Code Roadmap Dec 23, 2025

github-project-automation Bot moved this from Triage to Done in Roo Code Roadmap Dec 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: exclude parallel_tool_calls for Bedrock models in LiteLLM - #10235

fix: exclude parallel_tool_calls for Bedrock models in LiteLLM#10235
ghost wants to merge 3 commits into
mainfrom
fix/litellm-bedrock-parallel-tool-calls

ghost commented Dec 20, 2025 •

edited by ellipsis-dev Bot

Loading

Uh oh!

ghost commented Dec 20, 2025 •

edited by ghost

Loading

Uh oh!

ghost commented Dec 20, 2025 •

edited by ghost

Loading

Uh oh!

mrubens Dec 20, 2025

Uh oh!

hannesrudolph Dec 21, 2025

Uh oh!

ghost Dec 21, 2025 •

edited by ghost

Loading

Uh oh!

mrubens left a comment

Uh oh!

hannesrudolph commented Dec 21, 2025

Uh oh!

ghost commented Dec 21, 2025 •

edited by ghost

Loading

Uh oh!

ellipsis-dev Bot Dec 21, 2025

Uh oh!

ghost Dec 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ghost commented Dec 20, 2025 • edited by ellipsis-dev Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Testing

Uh oh!

ghost commented Dec 20, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 20, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrubens Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

hannesrudolph Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

ghost Dec 21, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrubens left a comment

Choose a reason for hiding this comment

Uh oh!

hannesrudolph commented Dec 21, 2025

Uh oh!

ghost commented Dec 21, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ellipsis-dev Bot Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

ghost Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ghost commented Dec 20, 2025 •

edited by ellipsis-dev Bot

Loading

ghost commented Dec 20, 2025 •

edited by ghost

Loading

ghost commented Dec 20, 2025 •

edited by ghost

Loading

ghost Dec 21, 2025 •

edited by ghost

Loading

ghost commented Dec 21, 2025 •

edited by ghost

Loading