[Fix] Restore command output display in the web task view - #1054
Merged
Conversation
Terminal commands render their output again as a collapsible block (collapsed by default, 400px cap) with an output copy button, and expanded details are restored for command items inside grouped tool calls. Expanded file-read contents stay hidden.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Command output is currently not rendered in the web task view: terminal command messages show only the command line and exit code, and expanded details are suppressed for command items inside grouped tool calls. This restores the output display.
Changes
AcpCommandOutputMessage.tsx— reintroduces theisOutputPresentcheck, so a command with output renders as a collapsible code block (collapsed by default, 400px max height) with an output copy button. Commands with no output still render as a plain header.tool-detail-visibility.ts— drops theexecute/execute_command/isExecutebranches fromhidesExpandedToolResult, restoring expandable details for command items in grouped tool messages and for execute-flavored calls routed throughAcpToolMessage.Scope
Expanded file-read contents remain hidden.
hidesExpandedToolResultkeeps itsread/isReadbranches, along with the internal-debug and subagent-payload handling it has since grown. Only the command path is changed.The structural changes that introduced
hidesExpandedToolResult(thecollapsible={showExpandedDetails}prop and conditionalToolContentinAcpToolMessage/AcpGroupedToolMessage) are left in place, since the subagent and internal-debug features now rely on them.Note for reviewers
Hiding this output was a deliberate change, made so that expanding a tool call would not surface raw command output in the transcript. Restoring it re-exposes that output to anyone who can view a task.
sanitizeSandboxPathStringstill runs over the text, but it only rewrites sandbox paths and does not redact other content. Worth a look if transcripts are shareable in your deployment.Testing
vitest runover the ACP message tests: 185 passedpnpm check-types:fastandpnpm lintclean