Skip to content

[Fix] Restore command output display in the web task view - #1054

Merged
mrubens merged 1 commit into
developfrom
fix/restore-task-view-command-output
Aug 3, 2026
Merged

[Fix] Restore command output display in the web task view#1054
mrubens merged 1 commit into
developfrom
fix/restore-task-view-command-output

Conversation

@mrubens

@mrubens mrubens commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Command output is currently not rendered in the web task view: terminal command messages show only the command line and exit code, and expanded details are suppressed for command items inside grouped tool calls. This restores the output display.

Changes

  • AcpCommandOutputMessage.tsx — reintroduces the isOutputPresent check, so a command with output renders as a collapsible code block (collapsed by default, 400px max height) with an output copy button. Commands with no output still render as a plain header.
  • tool-detail-visibility.ts — drops the execute / execute_command / isExecute branches from hidesExpandedToolResult, restoring expandable details for command items in grouped tool messages and for execute-flavored calls routed through AcpToolMessage.
  • Tests updated to match.

Scope

Expanded file-read contents remain hidden. hidesExpandedToolResult keeps its read / isRead branches, along with the internal-debug and subagent-payload handling it has since grown. Only the command path is changed.

The structural changes that introduced hidesExpandedToolResult (the collapsible={showExpandedDetails} prop and conditional ToolContent in AcpToolMessage / AcpGroupedToolMessage) are left in place, since the subagent and internal-debug features now rely on them.

Note for reviewers

Hiding this output was a deliberate change, made so that expanding a tool call would not surface raw command output in the transcript. Restoring it re-exposes that output to anyone who can view a task. sanitizeSandboxPathString still runs over the text, but it only rewrites sandbox paths and does not redact other content. Worth a look if transcripts are shareable in your deployment.

Testing

  • vitest run over the ACP message tests: 185 passed
  • pnpm check-types:fast and pnpm lint clean

Terminal commands render their output again as a collapsible block
(collapsed by default, 400px cap) with an output copy button, and
expanded details are restored for command items inside grouped tool
calls. Expanded file-read contents stay hidden.
@roomote-community

roomote-community Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 59e0f7e

@mrubens
mrubens merged commit 92ce134 into develop Aug 3, 2026
18 checks passed
@mrubens
mrubens deleted the fix/restore-task-view-command-output branch August 3, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant