[Fix] Prevent members from rewriting deployment environments - #1102
Merged
Conversation
Contributor
Author
daniel-lxs
marked this pull request as ready for review
August 4, 2026 20:44
daniel-lxs
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 4, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The web Settings path already required admin access, but the MCP environment write path accepted any resolvable user. That allowed deployment members to create or replace shared environment definitions.
Impact
Only active admins can create or update deployment environments through MCP. Existing administrator-driven environment setup remains supported, while member and invalid run-token writes now receive a 403 before request processing or data access.
The focused environment authorization suite and API typecheck pass. The API package-wide ESLint command is still blocked by five pre-existing warnings in unrelated Discord and GitHub tests; the repository pre-push oxlint, fast typechecks, residual lint, and knip checks pass.