Skip to content

[Fix] Prevent members from rewriting deployment environments - #1102

Merged
daniel-lxs merged 1 commit into
developfrom
fix/environment-write-acl-0sm1g25hoe2sf
Aug 4, 2026
Merged

[Fix] Prevent members from rewriting deployment environments#1102
daniel-lxs merged 1 commit into
developfrom
fix/environment-write-acl-0sm1g25hoe2sf

Conversation

@roomote-community

Copy link
Copy Markdown
Contributor

Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Require an active deployment admin for MCP environment create and update requests.
  • Resolve task-run writes against the current live acting user and fail closed when the run binding is missing, malformed, or cannot be loaded.
  • Cover direct users and task-run actors across admin, member, deleted-user, and missing-run authorization cases.

Why this change was made

The web Settings path already required admin access, but the MCP environment write path accepted any resolvable user. That allowed deployment members to create or replace shared environment definitions.

Impact

Only active admins can create or update deployment environments through MCP. Existing administrator-driven environment setup remains supported, while member and invalid run-token writes now receive a 403 before request processing or data access.

The focused environment authorization suite and API typecheck pass. The API package-wide ESLint command is still blocked by five pre-existing warnings in unrelated Discord and GitHub tests; the repository pre-push oxlint, fast typechecks, residual lint, and knip checks pass.

@roomote-community

roomote-community Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed 188525d

@daniel-lxs
daniel-lxs marked this pull request as ready for review August 4, 2026 20:44
@daniel-lxs
daniel-lxs merged commit 140a12b into develop Aug 4, 2026
18 checks passed
@daniel-lxs
daniel-lxs deleted the fix/environment-write-acl-0sm1g25hoe2sf branch August 4, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants