[Fix] Tasks crash when agents read icon files - #1103
Merged
Conversation
Contributor
Author
|
No new code issues found. See task
Reviewed 6b75d4d |
Contributor
Author
mrubens
marked this pull request as ready for review
August 4, 2026 19:56
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 4, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a managed OpenCode safety hook that rejects reads of ICO and CUR files before their binary content can be attached to the model conversation. The hook checks both the requested path and its resolved filesystem target so a safe-looking symlink cannot bypass the guard. It accepts the supported OpenCode read argument shapes, preserves ordinary file and image reads, and returns guidance for text-only inspection or safe conversion.
Added focused coverage for case-insensitive extensions, Windows-style paths, query-suffixed paths, hook argument variants, safe and blocked symlink targets, ordinary reads, and worker bootstrap installation.
Why this change was made
OpenCode can treat icon files returned by the read tool as model image input even though inference providers do not consistently support those formats. The resulting provider failure could terminate an otherwise healthy task.
Impact
Attempts to read unsupported icon formats, including through symlink aliases, now fail as a recoverable tool error before reaching the model provider. Other read operations and tools are unchanged.