[Feat] Remove configuration for every source-control provider - #1119
Merged
brunobergher merged 4 commits intoAug 5, 2026
Merged
Conversation
Contributor
|
No new code issues found. See task
Reviewed cab6885 |
…trol-clear-config-0xrpn6ri8rlvm
Contributor
Author
|
Fixed the OAuth refresh race and resolved the |
brunobergher
marked this pull request as ready for review
August 5, 2026 16:16
brunobergher
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 5, 2026 16:16
brunobergher
approved these changes
Aug 5, 2026
brunobergher
deleted the
feature/source-control-clear-config-0xrpn6ri8rlvm
branch
August 5, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sourceControl.clearConfig({ provider })support for every source-control provider.Why this change was made
GitLab, Gitea, Bitbucket, and Azure DevOps could be configured in Roomote but lacked the complete local disconnect flow already available for GitHub. This makes provider setup and removal behavior consistent without deleting repository history or modifying deployment runtime variables.
Impact
Admins can safely remove persisted configuration for any source-control provider. External hook failures are reported without blocking local cleanup, repository rows and mappings remain available as inactive history, runtime-only providers remain connected, and concurrent token refreshes cannot restore removed OAuth secrets. Browser screenshots are omitted because the seeded development environment had no persisted non-GitHub provider configuration from which to open the removal dialogs without creating external OAuth state.