Skip to content

[Fix] PR reviews send duplicate action offers - #1161

Merged
daniel-lxs merged 2 commits into
developfrom
fix/dedupe-pr-review-notifications-3ikqvagh1k2om
Aug 7, 2026
Merged

[Fix] PR reviews send duplicate action offers#1161
daniel-lxs merged 2 commits into
developfrom
fix/dedupe-pr-review-notifications-3ikqvagh1k2om

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Daniel Riccio. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Carry the reviewed commit SHA through PR review activity events.
  • Treat a terminal Roomote-authored review summary as the canonical notification for that review pass.
  • Resolve deployment-configured GitHub App slugs before identifying Roomote-authored summaries in the notification worker.
  • Suppress matching Roomote-authored inline review activity while preserving human feedback, different commits, in-progress summaries, and marker-shaped comments from other authors.

Why this change was made

A completed Roomote review could produce both an immediate detailed summary and a delayed generic inline-comment notification, each with its own action buttons. Correlating both paths by reviewed commit keeps the inline path as a fallback without sending a duplicate offer after the canonical summary exists.

Impact

Users receive one actionable notification for a completed Roomote review instead of two duplicate-looking messages and button sets, including deployments that use a custom GitHub App slug. Human review activity and fallback notifications for incomplete or separate review passes continue to be delivered.

@roomote-community

roomote-community Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • packages/sdk/src/server/lib/task-runs/pr-review-notification-delivery.ts:577 - Resolve the configured GitHub App slug in the BullMQ process before identifying Roomote-authored summaries, so custom-slug deployments suppress duplicate review activity.

Reviewed 5702d03

Comment thread packages/sdk/src/server/lib/task-runs/pr-review-notification-delivery.ts Outdated
@daniel-lxs
daniel-lxs marked this pull request as ready for review August 7, 2026 21:47
@daniel-lxs
daniel-lxs merged commit 371cdf7 into develop Aug 7, 2026
18 checks passed
@daniel-lxs
daniel-lxs deleted the fix/dedupe-pr-review-notifications-3ikqvagh1k2om branch August 7, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant