Skip to content

[Fix] Auto-start channels appear unresponsive when task launch fails - #1193

Merged
daniel-lxs merged 3 commits into
developfrom
fix/auto-start-failure-message-0zt6y858hkyif
Aug 10, 2026
Merged

[Fix] Auto-start channels appear unresponsive when task launch fails#1193
daniel-lxs merged 3 commits into
developfrom
fix/auto-start-failure-message-0zt6y858hkyif

Conversation

@roomote-community

@roomote-community roomote-community Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Reply in Slack and Discord auto-start channels when launch classification or task startup fails unexpectedly.
  • Only reply to human-authored messages: failures on bot-authored messages (e.g. automated alert or deploy feeds) stay log-only, so a sustained classifier or startup outage cannot post a retry reply for every feed message.
  • Keep intentional launch-criteria skips silent (including rate-limited skips, now documented in-code) and preserve the more specific deployment read-only response.
  • Make Slack routing diagnostics best-effort so diagnostic failures cannot produce false launch-failure messages or suppress real ones.

Why this change was made

Auto-start failures were previously logged without any channel response, making Roomote appear unresponsive even when it had received the message and could still communicate with the user.

Impact

Users now receive a concise retry message for recoverable auto-start failures in Slack and Discord. Successful launches, intentional criteria-based skips, and bot-authored feed messages are unchanged.

@roomote-community

roomote-community Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

No new code issues found. See task

Reviewed 9cb95c0

Launch-criteria channels are commonly wired to automated feeds, and
classifier_error returns before the launch rate cap increments, so a
sustained classifier or startup outage would reply "please try again"
to every feed message with nothing throttling it. Bot-authored failures
now stay log-only; human-authored messages keep the failure reply.

@daniel-lxs daniel-lxs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full diff and ran the suite locally, pushed a follow-up so failure replies are human-only, a classifier or startup outage in a channel watching a bot feed would otherwise reply to every feed message. Criteria and rate-limit skips stay silent, read-only keeps its specific message.

@daniel-lxs
daniel-lxs marked this pull request as ready for review August 10, 2026 17:28
@daniel-lxs
daniel-lxs merged commit 7f7b394 into develop Aug 10, 2026
18 checks passed
@daniel-lxs
daniel-lxs deleted the fix/auto-start-failure-message-0zt6y858hkyif branch August 10, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants