[Fix] Auto-start channels appear unresponsive when task launch fails - #1193
Merged
daniel-lxs merged 3 commits intoAug 10, 2026
Merged
Conversation
Contributor
Author
Launch-criteria channels are commonly wired to automated feeds, and classifier_error returns before the launch rate cap increments, so a sustained classifier or startup outage would reply "please try again" to every feed message with nothing throttling it. Bot-authored failures now stay log-only; human-authored messages keep the failure reply.
daniel-lxs
approved these changes
Aug 10, 2026
daniel-lxs
left a comment
Member
There was a problem hiding this comment.
Reviewed the full diff and ran the suite locally, pushed a follow-up so failure replies are human-only, a classifier or startup outage in a channel watching a bot feed would otherwise reply to every feed message. Criteria and rate-limit skips stay silent, read-only keeps its specific message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Auto-start failures were previously logged without any channel response, making Roomote appear unresponsive even when it had received the message and could still communicate with the user.
Impact
Users now receive a concise retry message for recoverable auto-start failures in Slack and Discord. Successful launches, intentional criteria-based skips, and bot-authored feed messages are unchanged.