Restore agent access to authenticated previews - #1200
Merged
mrubens merged 5 commits intoAug 10, 2026
Conversation
Contributor
|
No new code issues found. See task
Reviewed 0a6353d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ROOMOTE_<NAME>_PREVIEW_URL, including ports that ultimately redirect to a direct machine URLROOMOTE_*_HOSTandROOMOTE_*_PREVIEW_URLdomains beforeagent-browsernavigationWhy
For an unproxied port,
ROOMOTE_<NAME>_HOSTintentionally points at the direct machine domain, while the human-facing Live Preview first enters through an authenticated preview-proxy domain. The browser wrapper previously seeded only the direct host. The credential was present, but its cookie was scoped to the wrong domain, so opening the shareable URL redirected the agent to Roomote sign-in.This preserves the existing direct-host contract while separately exposing and authenticating the shareable preview entrypoint.
Validation
pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/worker exec vitest run src/commands/__tests__/utils.test.ts src/run-task/__tests__/sandbox-instruction.test.ts src/commands/setup/__tests__/legacy-runtime-tools.test.tspnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/controller exec vitest run src/__tests__/utils.test.tspnpm --filter @roomote/worker check-typespnpm --filter @roomote/controller check-typesbash -n .docker/sandbox/install-browser-agent.sh